Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757137AbdLPS3Y (ORCPT <rfc822;w@1wt.eu>);
        Sat, 16 Dec 2017 13:29:24 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35971 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756930AbdLPS3W (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 16 Dec 2017 13:29:22 -0500
X-Google-Smtp-Source: ACJfBos4/tEUKugN8wOaQqllliCKb475Pq0FHSLUwLbrkmVXYUR2wCvzcl5afhVFc42TP4rh+6O2WY16L0S2kG82gNQ=
MIME-Version: 1.0
In-Reply-To: <20171216145751.3486-4-jiaxun.yang@flygoat.com>
References: <20171216145751.3486-1-jiaxun.yang@flygoat.com> <20171216145751.3486-4-jiaxun.yang@flygoat.com>
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Sat, 16 Dec 2017 19:28:40 +0100
Message-ID: <CAOFm3uHEmY-0y5qUDpLW+WLyi+TJd6LeV4qRhbhaXmCtX05mbw@mail.gmail.com>
Subject: Re: [PATCH v5 3/5] MIPS: Loongson64: Yeeloong add platform driver
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: James Hogan <jhogan@kernel.org>, Ralf Baechle <ralf@linux-mips.org>,
        Linux MIPS <linux-mips@linux-mips.org>,
        Huacai Chan <chenhc@lemote.com>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1170
Lines: 40

Dear Jiaxun,

On Sat, Dec 16, 2017 at 3:57 PM, Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> Yeeloong is a laptop with a MIPS Loongson 2F processor, AMD CS5536
> chipset, and KB3310B controller.

<snip>

> --- /dev/null
> +++ b/drivers/platform/mips/yeeloong_laptop.c
> @@ -0,0 +1,1142 @@
> +/*
> + * Driver for YeeLoong laptop extras
> + *
> + *  Copyright (C) 2017 Jiaxun Yang.
> + *  Author: Jiaxun Yang <jiaxun.yang@flygoat.com>
> + *
> + *  Copyright (C) 2009 Lemote Inc.
> + *  Author: Wu Zhangjin <wuzhangjin@gmail.com>, Liu Junliang <liujl@lemote.com>
> + *
> + *  Fixes: Petr Pisar <petr.pisar@atlas.cz>, 2012, 2013, 2014, 2015.
> + *
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License version 2 as
> + *  published by the Free Software Foundation.
> + */

Would you mind using the new SPDX tags here. See Thomas patches [1]

> +MODULE_LICENSE("GPL");

Also please make sure your module license (here GPL 2.0 or later per
module.h) matches your top level license tag  correctly (here GPL 2.0
only)?

[1] https://lkml.org/lkml/2017/12/4/934

-- 
Cordially
Philippe Ombredanne