Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757246AbdLQDwW (ORCPT ); Sat, 16 Dec 2017 22:52:22 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46620 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756984AbdLQDwT (ORCPT ); Sat, 16 Dec 2017 22:52:19 -0500 Date: Sat, 16 Dec 2017 22:52:12 -0500 (EST) Message-Id: <20171216.225212.1791534849895795249.davem@davemloft.net> To: redmcg@redmandi.dyndns.org Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: icmp6: Allow icmp messages to be looped back From: David Miller In-Reply-To: <1513163697-21136-1-git-send-email-redmcg@redmandi.dyndns.org> References: <1513163697-21136-1-git-send-email-redmcg@redmandi.dyndns.org> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 16 Dec 2017 19:52:16 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 25 From: Brendan McGrath Date: Wed, 13 Dec 2017 22:14:57 +1100 > One example of when an ICMPv6 packet is required to be looped back is > when a host acts as both a Multicast Listener and a Multicast Router. > > A Multicast Router will listen on address ff02::16 for MLDv2 messages. > > Currently, MLDv2 messages originating from a Multicast Listener running > on the same host as the Multicast Router are not being delivered to the > Multicast Router. This is due to dst.input being assigned the default > value of dst_discard. > > This results in the packet being looped back but discarded before being > delivered to the Multicast Router. > > This patch sets dst.input to ip6_input to ensure a looped back packet > is delivered to the Multicast Router. > > Signed-off-by: Brendan McGrath Ok, after a lot of consideration this seems like a reasonable way to solve this problem. Applied, thank you.