Message-ID: <1513504313.3214.2.camel@gmail.com>
Subject: Re: [PATCH 1/4] Staging: rtl8723bs: Replace true with x and false
 with !x
From: Shreeya Patel <shreeya.patel23498@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Sun, 17 Dec 2017 15:21:53 +0530
In-Reply-To: <1513503952.31581.24.camel@perches.com>
References: <cover.1513501504.git.shreeya.patel23498@gmail.com>
         <6a57c658e7e0e66c9d7e9496769593cad4399647.1513501505.git.shreeya.patel23498@gmail.com>
         <1513503952.31581.24.camel@perches.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 876
Lines: 28

On Sun, 2017-12-17 at 01:45 -0800, Joe Perches wrote:
> On Sun, 2017-12-17 at 15:07 +0530, Shreeya Patel wrote:
> > 
> > Replace true and false keywords with "x" and "!x"
> > respectively to follow the kernel coding style.
> []
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> > b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> []
> > 
> > @@ -191,8 +191,8 @@ static u32 sdio_read32(struct intf_hdl
> > *pintfhdl, u32 addr)
> >  	rtw_hal_get_hwreg(padapter, HW_VAR_APFM_ON_MAC,
> > &bMacPwrCtrlOn);
> >  	if (
> >  		((deviceId == WLAN_IOREG_DEVICE_ID) && (offset <
> > 0x100)) ||
> > -		(false == bMacPwrCtrlOn) ||
> > -		(true == adapter_to_pwrctl(padapter)-
> > >bFwCurrentInPSMode)
> > +		(!bMacPwrCtrlOn) ||
> When you do these sorts of conversions can you
> please remove the unnecessary parentheses too?
> 
Yes, surely I'll keep this in mind.

Thank you