Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757358AbdLQOZU (ORCPT ); Sun, 17 Dec 2017 09:25:20 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:45867 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757207AbdLQOZS (ORCPT ); Sun, 17 Dec 2017 09:25:18 -0500 X-Google-Smtp-Source: ACJfBosZnjippDWtv1AY5Dq2aRUhB2XXR25WfG0VYen43D4KfJ7DXWfW44HFdSW3GdxZlWq1Ag6URTcw3SicQpk6dOA= MIME-Version: 1.0 In-Reply-To: <20171217131705.GA30726@1wt.eu> References: <20171217120503.GA3323@1wt.eu> <20171217133355.618e5f92@bbrezillon> <20171217131705.GA30726@1wt.eu> From: Ezequiel Garcia Date: Sun, 17 Dec 2017 11:25:16 -0300 Message-ID: Subject: Re: pxa3xx_nand times out in 4.14 with JFFS2 To: Willy Tarreau Cc: Boris Brezillon , "linux-mtd@lists.infradead.org" , Robert Jarzmik , linux-arm-kernel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBHEPPVv014091 Content-Length: 1692 Lines: 50 On 17 December 2017 at 10:17, Willy Tarreau wrote: > Hi Boris! > > On Sun, Dec 17, 2017 at 01:33:55PM +0100, Boris Brezillon wrote: >> You should have a look at this thread [1], and in case you don't want >> to read everything, > > I've read it entirely, it was very instructive! > >> you can just test the solution proposed here [2]. >> >> [1]http://linux-mtd.infradead.narkive.com/Rd5UaRPO/bug-pxa3xx-wait-time-out-when-scanning-for-bb >> [2]http://patchwork.ozlabs.org/patch/847411/ > > Well done for such a quick reply! I can confirm that your proposed > patch below does fix it for me! Now I understand why only jffs2 was > triggering the issue if it only affects OOB, and I guess I would have > faced it as well with nanddump had I thought about testing it. > > I'm queuing this one here to continue to progress on my machine, feel > free to add my tested-by if the patch gets merged, or to ping me to > test any other option you'd like to confirm! > > Thanks! > Willy > > --- > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 321a90c..adb9fd8 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -950,6 +950,7 @@ static void prepare_start_command(struct pxa3xx_nand_info *info, int command) > > switch (command) { > case NAND_CMD_READ0: > + case NAND_CMD_READOOB: > case NAND_CMD_PAGEPROG: > info->use_ecc = 1; > break; > > If we can confirm that with this patch, bad block markers can be read without issues, then it's good to go. Willy, think you could try to test that? -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar