Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757524AbdLQTtd (ORCPT ); Sun, 17 Dec 2017 14:49:33 -0500 Received: from www62.your-server.de ([213.133.104.62]:58070 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757306AbdLQTtc (ORCPT ); Sun, 17 Dec 2017 14:49:32 -0500 Subject: Re: [PATCH] trace: reenable preemption if we modify the ip To: Josef Bacik , netdev@vger.kernel.org, mhiramat@kernel.org, ast@kernel.org, darrick.wong@oracle.com, linux-kernel@vger.kernel.org Cc: Josef Bacik References: <1513392177-10298-1-git-send-email-josef@toxicpanda.com> From: Daniel Borkmann Message-ID: Date: Sun, 17 Dec 2017 20:49:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1513392177-10298-1-git-send-email-josef@toxicpanda.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 504 Lines: 12 On 12/16/2017 03:42 AM, Josef Bacik wrote: > From: Josef Bacik > > Things got moved around between the original bpf_override_return patches > and the final version, and now the ftrace kprobe dispatcher assumes if > you modified the ip that you also enabled preemption. Make a comment of > this and enable preemption, this fixes the lockdep splat that happened > when using this feature. > > Signed-off-by: Josef Bacik Applied to bpf-next with Fixes tag, thanks Josef.