Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757549AbdLQVRP (ORCPT ); Sun, 17 Dec 2017 16:17:15 -0500 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:37560 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757336AbdLQVRO (ORCPT ); Sun, 17 Dec 2017 16:17:14 -0500 Date: Sun, 17 Dec 2017 22:16:50 +0100 From: Willy Tarreau To: Ezequiel Garcia Cc: Boris Brezillon , "linux-mtd@lists.infradead.org" , Robert Jarzmik , linux-arm-kernel , "linux-kernel@vger.kernel.org" Subject: Re: pxa3xx_nand times out in 4.14 with JFFS2 Message-ID: <20171217211650.GA6815@1wt.eu> References: <20171217120503.GA3323@1wt.eu> <20171217155305.16c5bb4f@bbrezillon> <20171217150043.GA1403@1wt.eu> <20171217162342.GA1833@1wt.eu> <20171217190746.2a61232c@bbrezillon> <20171217190056.GA1107@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1410 Lines: 32 On Sun, Dec 17, 2017 at 06:01:29PM -0300, Ezequiel Garcia wrote: > On 17 December 2017 at 16:00, Willy Tarreau wrote: > > On Sun, Dec 17, 2017 at 07:07:46PM +0100, Boris Brezillon wrote: > >> > > This would guarantee that devices with factory bad blocks, > >> > > (and no BBT), would be OK with this patch. > >> > > >> > I see. I'm fine with trying provided I have reasonably good assurance > >> > that I won't have to go through the kwboot pain again :-/ > >> > >> There's a easy test you can do without scrubing the NAND: > >> 1/ comment the nand-on-flash-bbt property in your DT (this will trigger > >> a full scan) > >> 2/ from u-boot (before booting the kernel), erase a block that you know > >> contains nothing important > >> 3/ during the kernel scan, make sure this block is not reported as bad > > > > OK so I tried and never faced any error. Thus I also attempted to mark > > a bad block in u-boot, it appeared in the bad blocks table, then I had > > to scrub the whole table to get rid of it. Each time when I booted I > > saw the message "Scanning device for bad blocks" but no error ever > > happened. So I hope it's OK. > > > > Nice. Thanks a lot Willy. I think this acks Boris' patch. You're welcome, you and Boris fixed my problem very quickly allowing me to continue to prepare my new router :-) BTW, Boris please don't forget to mark your fix for -stable. Thanks, Willy