Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757589AbdLQVqX convert rfc822-to-8bit (ORCPT ); Sun, 17 Dec 2017 16:46:23 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:36982 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757510AbdLQVqV (ORCPT ); Sun, 17 Dec 2017 16:46:21 -0500 Date: Sun, 17 Dec 2017 22:46:17 +0100 From: Miquel RAYNAL To: Boris Brezillon Cc: Willy Tarreau , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , Ezequiel Garcia , Robert Jarzmik , linux-arm-kernel Subject: Re: pxa3xx_nand times out in 4.14 with JFFS2 Message-ID: <20171217224617.1f9b8b84@xps13> In-Reply-To: <20171217222611.59f9031b@bbrezillon> References: <20171217120503.GA3323@1wt.eu> <20171217155305.16c5bb4f@bbrezillon> <20171217150043.GA1403@1wt.eu> <20171217162342.GA1833@1wt.eu> <20171217190746.2a61232c@bbrezillon> <20171217190056.GA1107@1wt.eu> <20171217211650.GA6815@1wt.eu> <20171217222611.59f9031b@bbrezillon> Organization: Free Electrons X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2778 Lines: 75 Hello Willy, On Sun, 17 Dec 2017 22:26:11 +0100 Boris Brezillon wrote: > +Miquel > > On Sun, 17 Dec 2017 22:16:50 +0100 > Willy Tarreau wrote: > > > On Sun, Dec 17, 2017 at 06:01:29PM -0300, Ezequiel Garcia wrote: > > > On 17 December 2017 at 16:00, Willy Tarreau wrote: > > > > On Sun, Dec 17, 2017 at 07:07:46PM +0100, Boris Brezillon > > > > wrote: > > > >> > > This would guarantee that devices with factory bad blocks, > > > >> > > (and no BBT), would be OK with this patch. > > > >> > > > > >> > I see. I'm fine with trying provided I have reasonably good > > > >> > assurance that I won't have to go through the kwboot pain > > > >> > again :-/ > > > >> > > > >> There's a easy test you can do without scrubing the NAND: > > > >> 1/ comment the nand-on-flash-bbt property in your DT (this > > > >> will trigger a full scan) > > > >> 2/ from u-boot (before booting the kernel), erase a block that > > > >> you know contains nothing important > > > >> 3/ during the kernel scan, make sure this block is not > > > >> reported as bad > > > > > > > > OK so I tried and never faced any error. Thus I also attempted > > > > to mark a bad block in u-boot, it appeared in the bad blocks > > > > table, then I had to scrub the whole table to get rid of it. > > > > Each time when I booted I saw the message "Scanning device for > > > > bad blocks" but no error ever happened. So I hope it's OK. > > > > > > > > > > Nice. Thanks a lot Willy. I think this acks Boris' patch. > > > > You're welcome, you and Boris fixed my problem very quickly > > allowing me to continue to prepare my new router :-) > > > > BTW, Boris please don't forget to mark your fix for -stable. > > Actually, if things go well it will only be applied to stable > releases (I really hope we'll be able to switch to Miquel's driver in > 4.16). BTW, if you have some time, maybe you can test Miquel's [1] > branch and let us know if it still works properly. As Boris said, we would really welcome a test of this branch, because you almost have the same setup as Sean in the thread "pxa3xx: wait time out when scanning for bb" and I am running out of explanation for his problem unless it is related to U-Boot. So if you could try booting with and without the on-flash-bbt property and report whether it fails or not it would be of great help! Thanks, Miquèl > > Thanks, > > Boris > > [1]https://github.com/miquelraynal/linux/tree/marvell/nand-next/nfc > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Miquel Raynal, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com