Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757622AbdLRAf0 (ORCPT ); Sun, 17 Dec 2017 19:35:26 -0500 Received: from relmlor4.renesas.com ([210.160.252.174]:15971 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756913AbdLRAfY (ORCPT ); Sun, 17 Dec 2017 19:35:24 -0500 X-IronPort-AV: E=Sophos;i="5.45,419,1508770800"; d="scan'208";a="265387404" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <87po7criel.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH v4 1/2] drm: rcar-du: use 1000 to avoid misunderstanding in rcar_du_dpll_divider() User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Laurent , Geert Uytterhoeven , David Airlie Cc: Linux-Renesas , Linux-Kernel , dri-devel@lists.freedesktop.org In-Reply-To: <87r2rsrifu.wl%kuninori.morimoto.gx@renesas.com> References: <87r2rsrifu.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Date: Mon, 18 Dec 2017 00:35:18 +0000 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: TY1PR01CA0174.jpnprd01.prod.outlook.com (2603:1096:402::26) To KL1PR0601MB1879.apcprd06.prod.outlook.com (2603:1096:802:8::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7fb90c43-0bcb-4c79-febd-08d545af3795 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);SRVR:KL1PR0601MB1879; X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1879;3:LVla/8HFB2BV0vEEs+BF8p+zcwHJndzf5GH8eCNES3n7zGlBWmQ+lf3E4S949SrXCNorR7t1rKde7jcmbjfpN5KUBUXd0xtuYgWRwlAcQtP1x+9kFq3TZuuwGldvwe8ddZN35rlKEHgCuPNLhdQ3xpTFFNDzJr4uZJUV/YMzA5wZQRGj2WaSrcuWILz9O7D7Z1B2HI6K1JYw4jn2570mIR+qRRxBGzh4T/B+zFVE2uY3qjK0yhJtHyAvkrf3HEQ8;25:soBHdWU40GBwcmZMAB2wFfz2pzAP0Y05FwvkEHIBuuXCSb4mS94khpMzfruIqiWvb+2IqeGQvYcJw3vRAI5fLObMmk65kQNqm7KZ9azHevAuapS6RG1GCVhygftIjOmZtDVLrk7EkK9m5iAJA49jtB/LpBPPRhwKgd9tuQbwnGqzU0MvIhGYYOJse54HMO9f1AWDqYqHp2XhkNebF7vQPq9Eu7GRK3F28x4beUmFm5gp2iH4AKbebMfCH9ZTZvADs0WlgFGeoTnia1/ciHh0uE3/RiutbBLzxO2Kmt9LLZoes3ZaS+Nkx+CJGTrYqpxPT/0XsvV7X21mEji1Y5FyC+yyKvdEaZBsmmDyINoyNn8=;31:Z1rWDuBodotYia+i9cHAdBA+6lUqX21ukzcscdOjjt7F+HZ3vbYmvgmfes2izsedkWIyXcV6AA1xj+p2Vf1R46SY7b8KM8/r7dBYe4l/DNYhm2n9dURl+JMDqFGEFtaoHn4MBYhr95rTW3ZUh6f7au3CDg0kU9Q/4dqJ9U6gdcdIecp1gax92GmccgiECbadkr7c5rP2tatwg/mFcI15H8bRwZMm1zx1h5d+yV3U1QM= X-MS-TrafficTypeDiagnostic: KL1PR0601MB1879: X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1879;20:kIFi5on7DRBr4Of5+SRM/QkVDbQsLvnga4MnGZrjpGa3yG5s9+s3jcUtE9I2XY4MI4w4+81etKKlrtCCYJt0VFVo4WcIk5uYa45/WncboZnRaKX/Ckbne7SUE4+oaE7CPYxXqeWNMWfvPGh4/Aosh6qkGbQ/AhttVPCvg0SMPzX9ZluvE7QxYIs737HiwoRD6DjDfSeC1a+52uFXLD5XNiBJ11F+rUwaSOuBBR2Sytv9q5tz35jXcw+hz/nnk7FZ7t7ABusKxRsIu9wMQEOXZ/abC3W3IkYHfqw2O6b8nyxmKGPiAvx9fQ+WyyxLlJ2EHuSWxuQ3+prpDqIBs7t75lJ8N6tMbvyXx0v0zCjzzGokzkxR0XOVS2OlY93mGR6AaMRDWp5I/iajSC9AYvqb+LacIbITDN4PCyKpUPCf0iXM8Jth5ksVFyyTOThobyXTJpvCReb8U/m/F6/AhTd6PL974nyR/2Vqvqxqf2v0575eIiCGkh+5MHT5U8jJaNv2;4:dlaFryvZxqoIsc/elOaI02pxSPKZ3CsaTmR2eIsFjQw1U9kk0WegQiWRKY9BaMRgO8BTAYPym8Urt8IAr5lR6HV44/UTViW/m4Tcfr7NdTufAMxp3NXePiOdJxx2M1lopkWE2ULXK6hNxD3wzAmZm9aKog2nNd+KXWtg5yO1elEf+yvgwjujGGTwrqdWKAMUuBoLAWO4WEve6XzVukB8Ckai0cQO+lRGyAJbzCH6dK6QuwTJMqDStFlTmAng+GXyTRTtnoZaOXr441LxuDM6qg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231023)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011);SRVR:KL1PR0601MB1879;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:KL1PR0601MB1879; X-Forefront-PRVS: 0525BB0ADF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(346002)(366004)(396003)(376002)(39850400004)(189003)(199004)(105586002)(16526018)(58126008)(50466002)(6486002)(386003)(110136005)(54906003)(7736002)(36756003)(52116002)(106356001)(68736007)(305945005)(2950100002)(59450400001)(76176011)(316002)(7696005)(16586007)(66066001)(53936002)(53416004)(25786009)(86362001)(478600001)(3846002)(4326008)(23726003)(97736004)(81156014)(8676002)(83506002)(2906002)(5660300001)(47776003)(69596002)(6116002)(8936002)(81166006)(221023002)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1PR0601MB1879;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;KL1PR0601MB1879;23:38hGY9Ea3wp2AZr2+DIF+p3zFL7RDr/am69nM87?= =?us-ascii?Q?HN9OhgG1DHC38GH1+jTdYVkArVaVpAupF1J//HWUrEsief5c/ixe9RNDlrkP?= =?us-ascii?Q?P8bWLrNziqM33jBR+rB9Nhx/5TPXdsfy/6vmqcLR+ERliTZ+9fBWYlKCTBMd?= =?us-ascii?Q?8mQ80rLC7KB0sgLPRfhNCeXndQRkNk+Kl7dOQ1Je7umXyUi7mHCJurubQJzF?= =?us-ascii?Q?FpYm7uvltisu/+1F6Fc6tl7hU+pUbzotgQruN2wQorvRlv+l1nSAH8a8a2w2?= =?us-ascii?Q?STawkP5snkFWe9Jdlw8SUZL2a70F6Yqow7DWgHNFnTBywijPlTv5JXat0fyK?= =?us-ascii?Q?rgH6QsQ70auH2ucmhAYwcyW3uCxRSXq5gPkz1bMH5srIaMwoQ3Fs6C/CRJjD?= =?us-ascii?Q?f+Qx6snJg+iYPTtaZguYnX5mTv3AjgoHs2nVguJNCSlabvjtVK9cN/29hzIF?= =?us-ascii?Q?m0422kjPB1Nt7rTNQ/YIY+Cl8siKJN31shUQ27fzncTX8vAMqJdtTY2C4HlC?= =?us-ascii?Q?eq9hGdhvfM2Vgz7/Uh7IkJg0a2p4UmsdVi67v6FHKKu4ZVC/Jazy4tF3oOQ+?= =?us-ascii?Q?fu2XvDussu9tckOcNGvCCnibxvDmXeYMwwjjZaa9VcbG4RHJeL1Y6fdWwpKs?= =?us-ascii?Q?xqifKuOeOYSPOz0DflrD2NPtXQZspYgovhLC7sNnEljUCSlrikcjQr1X6jAN?= =?us-ascii?Q?hxfeanEpb/OtYipems+4vXj4UiHrc6BooVoDicr/i8kwVDA+NfvhoPr1+ijs?= =?us-ascii?Q?dqGTLlzY9+nBtz09ARRtQXOm/bcoSUbYJnPI7006pQ8WO+6uvbkl7bf1EH0Z?= =?us-ascii?Q?qPMQaOokSGWHvzqenDk41P0nEbtS5wSJxgBZSuDy5BmTsSkfQk7U4eCe4DkD?= =?us-ascii?Q?2TvhTaK5g3FF/hhjkyWt1XQUY/yaFiftSUj2MyC8NSMbDleJO+FEQPSxpsO7?= =?us-ascii?Q?h0RkCbqlOuSIPz+TMg4o8qoV2lPzJbu6q+qzpIVw1K0Uf4ZFrPcuv+PB/TXT?= =?us-ascii?Q?8aSSs+u8BB2G6Po25Wis73hD57n9I1X7uGtbmf801O9RWsumhmnSumHIrYwf?= =?us-ascii?Q?xPQprklDMtPNZYOF+vY1SMwy7n1k6qFOVmKRM/KivbR0rAnE7zIVnef8zlwI?= =?us-ascii?Q?UyxOiGoK5LgwvHerdXdDk8wjYumP2gaKH?= X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1879;6:z8nmXVp9/Cl/IjY3gzlaO+O88MP7DU44S22JtRcywKb/h8Ha471OVa1+5be8LwEsxoWbieVRwJNle3TpzqwN9V5YN3VfqaAQwEyNUEXh2RF/GWEdJuMLTLGdobu41GGPqZi9mdUK2DDsIxy0ue3ocGC7NbO3FCHDL6YdAjv4ZV4HMW4e/5/0YmSbDot9wk62kvINSUR7U8Woo3Lz7sdWOcmtK3eWH/aTLRx3yxV5lNqc6va91EiEJLcO7QhMZZTt4vOkRQNBwr46Wc3F5lv5b0nEAmTRd4vxUQeIfhBXkPm2q3VN+YHGvtEoY3iTSX/sFVNpOu81NjgdMpLgLpwvYLoBgZrtRAwPGTipLTLlNSg=;5:ooXFe/yVpmkJ8NjwcTEQTLtvfeAIYw+C4p49RDdaTDWMNyRArcyfD4SJLITRFwfL39VfubiEfKcnutiaXYbJFNcfJnSE2qHgVFwC5ruJNqvFRN9tbzF8J5XaB6CiHGeA41WkYm8QtYRIpQMsjUZ6SkNQJs+Zu7sRYLd33hkWzME=;24:EZUXeRRu/iOp4vNyTBwuhpZuB9RzsDillnfggZNrbCtql+bk9HZ8ME3QYFzd7m/rPmmgI8Khlac64zXnCiRb+mtUZxF7XL9vy3EtUsCXCMY=;7:45O7Q07uQyQIMWa2QcffjANVYaKAlt4XP3JSgIGoqFycnoRZqa6VKtfap+nmLvRR40GiTxK3Sl+zcynubyGErV7jeLNk19hbL++H3fU9RkoL5Maek6ADSspaKPMzb90uz457hmJRS0DBxb/G3T+xIcgQ1QfIFJ/HzwhdObWsvPHaU1AW5jdMv6m/xL6EhNQnCV7jl+y0TXcK0AQj9DS9ZXmLPwY3i4X8jiVaSS0NPZj92eSwvWs/yKQ1RAsFj43F SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;KL1PR0601MB1879;20:5iCVVARzFsOhruBWEtVPLT73TfIFzXvDEfnZALfxnf4a6UMFide+XyQm1AFX6uYYS7v+AbBEIQEXXhHRxslRoTvbqp+wafT8LuR0wxnbu3C22qf6U4cst+Vc9n0quazXHu2IE7M9g6/B0C3i086PlmIZ6PMVRprXfDLPC9Jbp28= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2017 00:35:18.9932 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fb90c43-0bcb-4c79-febd-08d545af3795 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1879 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 29 From: Kuninori Morimoto It is difficult to understand its scale if number has many 0s. This patch uses "* 1000" to avoid it in rcar_du_dpll_divider(). Signed-off-by: Kuninori Morimoto --- v3 -> v4 - no change drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 5685d5a..6820461f 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c @@ -132,7 +132,7 @@ static void rcar_du_dpll_divider(struct rcar_du_crtc *rcrtc, output = input * (n + 1) / (m + 1) / (fdpll + 1); - if (output >= 400000000) + if (output >= 400 * 1000 * 1000) continue; diff = abs((long)output - (long)target); -- 1.9.1