Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440AbdLRHkv (ORCPT ); Mon, 18 Dec 2017 02:40:51 -0500 Received: from mail1.skidata.com ([91.230.2.99]:57869 "EHLO mail1.skidata.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdLRHku (ORCPT ); Mon, 18 Dec 2017 02:40:50 -0500 X-Greylist: delayed 597 seconds by postgrey-1.27 at vger.kernel.org; Mon, 18 Dec 2017 02:40:49 EST X-IronPort-AV: E=Sophos;i="5.45,421,1508796000"; d="scan'208";a="7689690" Subject: Re: [PATCH net-next v5 1/4] phylib: Add device reset delay support To: Rob Herring , Richard Leitner CC: , , , , , , , , , , , , , References: <20171211121700.10200-1-dev@g0hl1n.net> <20171211121700.10200-2-dev@g0hl1n.net> <20171215221752.42sz53izxeebkfuq@rob-hp-laptop> From: Richard Leitner Message-ID: <1b230e6b-8e8c-28a4-7524-6ce60aa71591@skidata.com> Date: Mon, 18 Dec 2017 08:30:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171215221752.42sz53izxeebkfuq@rob-hp-laptop> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.60.30] X-ClientProxiedBy: sdex1srv.skidata.net (172.16.10.92) To sdex1srv.skidata.net (172.16.10.92) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2102 Lines: 52 Hi Rob, On 12/15/2017 11:17 PM, Rob Herring wrote: > On Mon, Dec 11, 2017 at 01:16:57PM +0100, Richard Leitner wrote: >> From: Richard Leitner >> >> Some PHYs need a minimum time after the reset gpio was asserted and/or >> deasserted. To ensure we meet these timing requirements add two new >> optional devicetree parameters for the phy: reset-delay-us and >> reset-post-delay-us. >> >> Signed-off-by: Richard Leitner >> Reviewed-by: Geert Uytterhoeven >> --- >> Documentation/devicetree/bindings/net/phy.txt | 10 ++++++++++ >> drivers/net/phy/mdio_device.c | 13 +++++++++++-- >> drivers/of/of_mdio.c | 4 ++++ >> include/linux/mdio.h | 2 ++ >> 4 files changed, 27 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/phy.txt b/Documentation/devicetree/bindings/net/phy.txt >> index c05479f5ac7c..72860ce7f610 100644 >> --- a/Documentation/devicetree/bindings/net/phy.txt >> +++ b/Documentation/devicetree/bindings/net/phy.txt >> @@ -55,6 +55,12 @@ Optional Properties: >> >> - reset-gpios: The GPIO phandle and specifier for the PHY reset signal. >> >> +- reset-delay-us: Delay after the reset was asserted in microseconds. >> + If this property is missing the delay will be skipped. >> + >> +- reset-post-delay-us: Delay after the reset was deasserted in microseconds. >> + If this property is missing the delay will be skipped. > > I think these names could be clearer as to exactly what they mean. > Looking at existing properties with "reset-delay" there's a mixture of > definitions whether it is the assert time or the time after deassert. > > So I'd call these "reset-assert-us" and "reset-deassert-us". Ok, that would be fine with me, but are you sure that we should omit the "-delay" term completely? What would be the best approach to post this change (as the patchset was already merged to net-next)? A separate patch or a v6 of the complete patchset? > > Rob > regards;Richard.L