Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757778AbdLRHwg (ORCPT ); Mon, 18 Dec 2017 02:52:36 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:60740 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbdLRHwe (ORCPT ); Mon, 18 Dec 2017 02:52:34 -0500 Subject: Re: [PATCH v1] DMA:omap-dma:Avoid build error by changing the function name To: Vinod Koul , CC: , , References: <1513063721-13688-1-git-send-email-venkat.prashanth2498@gmail.com> <20171218052925.GP18649@localhost> From: Peter Ujfalusi Message-ID: <7d6c8529-df4c-056e-1135-73161037ae8d@ti.com> Date: Mon, 18 Dec 2017 09:52:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171218052925.GP18649@localhost> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2478 Lines: 80 On 2017-12-18 07:29, Vinod Koul wrote: > On Tue, Dec 12, 2017 at 12:58:41PM +0530, venkat.prashanth2498@gmail.com wrote: >> From: Venkat Prashanth B U >> >> Change the name of the function omap_dma_filter_fn to avoid >> the following build error in linux kernel version 4.4 : >> >> drivers/dma/dma-omap.c:1273:6: error: >> redefinition of 'omap_dma_filter_fn' What is your config regarding to omap_dma? in the include/linux/omap-dmaengine.h : #if defined(CONFIG_DMA_OMAP) || (defined(CONFIG_DMA_OMAP_MODULE) && defined(MODULE)) bool omap_dma_filter_fn(struct dma_chan *, void *); #else static inline bool omap_dma_filter_fn(struct dma_chan *c, void *d) { return false; } #endif DMA_OMAP enables the build of drivers/dma/omap-dma.c > > Okay I do not see this error, which tree are you running? I have not seen this either, and looking at the code I don't think it is possible. Not with what we have upstream. > In code is see omap_dma_filter_fn is used everywhere and no reference to > omap_dma_filter_func > > Adding peter too.. > > >> >> Signed-off-by: Venkat Prashanth B U >> Changes for v1: >> - Edited subject and description of the patch to fit with the change >> done in the code base, as suggested by Vinod Koul. >> >> - In order to avoid issues like backporting on stable the >> checkpatch.pl issues are dropped as suggested by Vinod Koul. >> --- >> drivers/dma/omap-dma.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c >> index 1dfc71c..8545dda 100644 >> --- a/drivers/dma/omap-dma.c >> +++ b/drivers/dma/omap-dma.c >> @@ -1269,7 +1269,7 @@ static struct platform_driver omap_dma_driver = { >> }, >> }; >> >> -bool omap_dma_filter_fn(struct dma_chan *chan, void *param) >> +bool omap_dma_filter_func(struct dma_chan *chan, void *param) this certainly breaks the omap_dma driver on non DT booted systems. >> { >> if (chan->device->dev->driver == &omap_dma_driver.driver) { >> struct omap_dmadev *od = to_omap_dma_dev(chan->device); >> -- >> 1.9.1 >> -- >> To unsubscribe from this list: send the line "unsubscribe dmaengine" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki