Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933020AbdLRJHT (ORCPT ); Mon, 18 Dec 2017 04:07:19 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:37664 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932714AbdLRJHO (ORCPT ); Mon, 18 Dec 2017 04:07:14 -0500 X-Google-Smtp-Source: ACJfBotHjRoxHRCdy03JbntZ9V8LTWZN1DyXhLmEKtQwbRhhWInPr6GZQvNy/tsBXdSPVU2EH+OpBg== Subject: Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy default features To: Lipeng , davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, salil.mehta@huawei.com References: <1513589500-121623-1-git-send-email-lipeng321@huawei.com> <1513589500-121623-15-git-send-email-lipeng321@huawei.com> From: Sergei Shtylyov Message-ID: Date: Mon, 18 Dec 2017 12:07:11 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1513589500-121623-15-git-send-email-lipeng321@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 723 Lines: 24 Hello! On 12/18/2017 12:31 PM, Lipeng wrote: > From: Fuyun Liang > > commit c4fb2cdf575d (net: hns3: fix a bug for phy supported feature > initialization) adds default supported features for phy, but our hardware Ten cited commit's summary needs to be enclosed in (""), not just ()... > also supports Asym Pause. This patch adds Asym Pause support to phy > default features to prevent Asym Pause can not be advertised when the phy > negotiates flow control. > > Fixes: c4fb2cdf575d (net: hns3: fix a bug for phy supported feature initialization) Here as well... > Signed-off-by: Fuyun Liang > Signed-off-by: Lipeng [...] MBR, Sergei