Date: Wed, 16 Jul 2003 14:02:54 -0700
From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] print_dev_t for 2.6.0-test1-mm
Message-ID: <20030716210253.GD2279@kroah.com>
References: <20030716184609.GA1913@kroah.com> <20030716130915.035a13ca.akpm@osdl.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030716130915.035a13ca.akpm@osdl.org>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1477
Lines: 44

On Wed, Jul 16, 2003 at 01:09:15PM -0700, Andrew Morton wrote:
> > Here's a patch against 2.6.0-test1-mm that fixes up the different places
> > where we export a dev_t to userspace.  This fixes all of the compiler
> > warnings that were previously reported with these files.
> 
> I added this as well:
> 
> static inline char *format_dev_t(char *buffer, dev_t dev)
> {
> 	sprintf(buffer, "%04lx\n", (unsigned long)dev);
> 	return buffer;
> }
> 
> tp be placed direct in a printk().

Nice.

> We'll probably need to do something more fancy in here later, because once
> a dev_t becomes 32:32, it'll need to be printed out with "%016llx", which
> is daft.
> 
> So we'll need to come up with some standardised way of presenting a dev_t
> to the user.  Presumably that will just be
> 
> 	sprintf(buf, "%d:%d", major(dev), minor(dev));
> 	
> But if we do this, will it break your existing stuff?

No, I don't think there are any users of udev right now :)

I wouldn't mind the ':' being there, makes my life a bit easier, but for
some reason Al Viro didn't want to do that a long time ago...

If we put the ':' in there, it protects userspace from having to deal
with different sized dev_t, so that really makes sense.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/