Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932792AbdLRK7Y (ORCPT ); Mon, 18 Dec 2017 05:59:24 -0500 Received: from mail.us.es ([193.147.175.20]:50800 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758095AbdLRK7U (ORCPT ); Mon, 18 Dec 2017 05:59:20 -0500 Date: Mon, 18 Dec 2017 11:59:15 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Florian Westphal Cc: Colin King , Jozsef Kadlecsik , "David S . Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][netfilter-next] netfilter: conntrack: make struct nf_conntrack_l4proto_gre4 static Message-ID: <20171218105915.cjqsqe2nmahm5yji@salvia> References: <20171210233255.15009-1-colin.king@canonical.com> <20171211091805.GK24449@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171211091805.GK24449@breakpoint.cc> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 26 On Mon, Dec 11, 2017 at 10:18:05AM +0100, Florian Westphal wrote: > Colin King wrote: > > From: Colin Ian King > > > > The structure nf_conntrack_l4proto_gre4 is local to the source and does > > not need to be in global scope, so make it static. > > This bug was added in > commit b9679a9fd3a7d36ea3deb2864a00cc413c5aae28 > netfilter: conntrack: l4 protocol trackers can be const I have added Fixes: ... here. > > -struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = { > > +static struct nf_conntrack_l4proto nf_conntrack_l4proto_gre4 = { > > This should be 'static const'. I have mangled this patch to make it static const. So Colin doesn't need to resend. If there's anything else, let me know, I'll toss it and wait for a v2, as you prefer. Thanks.