Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933085AbdLRMJo (ORCPT ); Mon, 18 Dec 2017 07:09:44 -0500 Received: from mail-oi0-f47.google.com ([209.85.218.47]:35394 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758697AbdLRMJl (ORCPT ); Mon, 18 Dec 2017 07:09:41 -0500 X-Google-Smtp-Source: ACJfBouBnyOhlKmoecFFWNwJJTFfarDy8xl0QO51oHOx4KEBcRDrNeiQW1cbXyI3eCKqrKPjgW+Bib8qMcxH4WSZqDs= MIME-Version: 1.0 In-Reply-To: <17d27b8d-908b-a740-1d2d-e92a8507f25b@redhat.com> References: <1513302050-14253-1-git-send-email-wanpeng.li@hotmail.com> <15b7b9e5-5b11-f20f-0260-5c8b9fc5e111@arm.com> <17d27b8d-908b-a740-1d2d-e92a8507f25b@redhat.com> From: Wanpeng Li Date: Mon, 18 Dec 2017 20:09:39 +0800 Message-ID: Subject: Re: [PATCH v4] KVM: Fix stack-out-of-bounds read in write_mmio To: Paolo Bonzini Cc: Marc Zyngier , "linux-kernel@vger.kernel.org" , kvm , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Wanpeng Li , Christoffer Dall Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 28 2017-12-18 19:55 GMT+08:00 Paolo Bonzini : > On 15/12/2017 12:06, Marc Zyngier wrote: >> Assuming you address the above: >> >> Reviewed-by: Marc Zyngier >> Tested-by: Marc Zyngier > > Done as follows: > > diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h > index dfd21708694f..0a016bd14c2d 100644 > --- a/include/trace/events/kvm.h > +++ b/include/trace/events/kvm.h > @@ -227,7 +227,8 @@ > __entry->gpa = gpa; > __entry->val = 0; > if (val) > - memcpy(&__entry->val, val, min(8, len)); > + memcpy(&__entry->val, val, > + min_t(u32, sizeof(__entry->val), len)); > ), > > TP_printk("mmio %s len %u gpa 0x%llx val 0x%llx", Thanks Paolo. :) Regards, Wanpeng Li