Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758335AbdLRNL1 (ORCPT ); Mon, 18 Dec 2017 08:11:27 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:37988 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbdLRNLW (ORCPT ); Mon, 18 Dec 2017 08:11:22 -0500 X-Google-Smtp-Source: ACJfBouUE92Z3I0tpcpE5EyfxgIFmMMBrYYhVVludwCJp5i1wW1yIZcGDwHJA1UD96UdVDjJ6r73mg== Date: Mon, 18 Dec 2017 13:11:19 +0000 From: Matt Fleming To: Ingo Molnar Cc: Dave Young , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, ard.biesheuvel@linaro.org Subject: Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap Message-ID: <20171218131119.GA3891@codeblueprint.co.uk> References: <20171130052327.GA3500@dhcp-128-65.nay.redhat.com> <20171214104119.GA2437@dhcp-128-65.nay.redhat.com> <20171215151822.GB3204@codeblueprint.co.uk> <20171216140632.462yk7pmlvpmz6if@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171216140632.462yk7pmlvpmz6if@gmail.com> User-Agent: Mutt/1.5.24+42 (6e565710a064) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 26 On Sat, 16 Dec, at 03:06:32PM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > > x86_init.oem.arch_setup(); > > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p) > > > > > > parse_early_param(); > > > > > > + if (efi_enabled(EFI_BOOT)) > > > + efi_memblock_x86_reserve_range(); > > > #ifdef CONFIG_MEMORY_HOTPLUG > > > /* > > > * Memory used by the kernel cannot be hot-removed because Linux > > > > > > > I prefer this version. Please re-send a full patch and update the > > subject line to include the "fix" somewhere; it wasn't obvious to me > > from the start that this is a bug fix. > > Agreed. > > I dropped the commit I just applied to tip:efi/core, since you are handling this, > so this patch should come through the regular EFI channels, right? Yep, that's right. Me or Ard will take care of it.