Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758625AbdLROZ4 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Dec 2017 09:25:56 -0500
Received: from mga05.intel.com ([192.55.52.43]:62372 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752688AbdLROZx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Dec 2017 09:25:53 -0500
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,422,1508828400"; 
   d="scan'208";a="2712071"
Subject: Re: perf record: regression with latest PT fix
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Stephane Eranian <eranian@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
References: <CABPqkBS10uwjVE+_OyYg0mVM8hbhxU9Jr9eBEFF8KQd_3j4SnQ@mail.gmail.com>
 <20171218132821.5gqxtwotgxvpqzy7@ukko.fi.intel.com>
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <f2ba3aeb-269d-8137-f7b8-13a658bff400@intel.com>
Date: Mon, 18 Dec 2017 16:25:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171218132821.5gqxtwotgxvpqzy7@ukko.fi.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 872
Lines: 36

On 18/12/17 15:28, Alexander Shishkin wrote:
> On Mon, Dec 18, 2017 at 05:03:53AM -0800, Stephane Eranian wrote:
>> Hi,
>>
>>
>> The following patch:
>>
>> f785657b0fbe perf report: Fix regression when decoding Intel-PT traces
> 
> Cc'ing Adrian in case he missed the patch.

Doesn't seem to have much to do with Intel PT, but the patch logic looks wrong:

 		ret = perf_evlist__parse_sample_timestamp(evlist, event, &timestamp);
-		if (ret)
+		if (ret != -1)
 			return ret;

Shouldn't that be:

 		ret = perf_evlist__parse_sample_timestamp(evlist, event, &timestamp);
-		if (ret)
+		if (ret && ret != -1)
 			return ret;


> 
>> is breaking perf report for me. I get no samples reported from perf report
>> when running simple perf record commands:
>>
>> $ perf record -e cycles noploop
>>
>> Reverting the patch fixes the problem.
>>
>> Are you seeing this as well?
>