Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758100AbdLRPB7 (ORCPT ); Mon, 18 Dec 2017 10:01:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50514 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752799AbdLRPB6 (ORCPT ); Mon, 18 Dec 2017 10:01:58 -0500 Date: Mon, 18 Dec 2017 16:02:00 +0100 From: Greg KH To: Dhaval Shah Cc: arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon Message-ID: <20171218150200.GA15318@kroah.com> References: <20171208081305.15153-1-dhaval.shah@softnautics.com> <20171208081305.15153-4-dhaval.shah@softnautics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171208081305.15153-4-dhaval.shah@softnautics.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 26 On Fri, Dec 08, 2017 at 01:43:05PM +0530, Dhaval Shah wrote: > Resolved all the macros should not use a trailing semicolon > checkpatch warnings. Issue found by checkpatch. > > Signed-off-by: Dhaval Shah > --- > drivers/misc/ad525x_dpot.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c > index 577f5e76c8a8..bc591b7168db 100644 > --- a/drivers/misc/ad525x_dpot.c > +++ b/drivers/misc/ad525x_dpot.c > @@ -515,11 +515,11 @@ set_##_name(struct device *dev, \ > #define DPOT_DEVICE_SHOW_SET(name, reg) \ > DPOT_DEVICE_SHOW(name, reg) \ > DPOT_DEVICE_SET(name, reg) \ > -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name); > +static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name) This should be using DEVICE_ATTR_RW() instead of DEVICE_ATTR(), care to fix that up in a follow-on patch for this driver? thanks, greg k-h