DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 533326032C
Subject: Re: [PATCH] net: qcom/emac: Change the order of mac up and sgmii open
To: Hemanth Puranik <hpuranik@codeaurora.org>,
        netdev <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <1513576667-2967-1-git-send-email-hpuranik@codeaurora.org>
From: Timur Tabi <timur@codeaurora.org>
Message-ID: <929926a6-f1d2-9c4c-7788-d5d9caf97e4d@codeaurora.org>
Date: Mon, 18 Dec 2017 10:05:56 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1513576667-2967-1-git-send-email-hpuranik@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 25

On 12/17/2017 11:57 PM, Hemanth Puranik wrote:
> This patch fixes the order of mac_up and sgmii_open for the
> reasons noted below:
> 
> - If open takes more time(if the SGMII block is not responding or
>    if we want to do some delay based task) in this situation we
>    will hit NETDEV watchdog
> - The main reason : We should signal to upper layers that we are
>    ready to receive packets "only" when the entire path is initialized
>    not the other way around, this is followed in the reset path where
>    we do mac_down, sgmii_reset and mac_up. This also makes the driver
>    uniform across the reset and open paths.
> - In the future there may be need for delay based tasks to be done in
>    sgmii open which will result in NETDEV watchdog
> - As per the documentation the order of init should be sgmii, mac, rings
>    and DMA
> 
> Signed-off-by: Hemanth Puranik<hpuranik@codeaurora.org>

Acked-by: Timur Tabi <timur@codeaurora.org>

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.