Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936708AbdLRQnG (ORCPT ); Mon, 18 Dec 2017 11:43:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936088AbdLRQNk (ORCPT ); Mon, 18 Dec 2017 11:13:40 -0500 Subject: Re: [PATCH] KVM: vmx: speed up MSR bitmap merge To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, bsd@redhat.com, jmattson@google.com References: <1513171828-5130-1-git-send-email-pbonzini@redhat.com> <854645993.27733836.1513612982078.JavaMail.zimbra@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <47c89e16-5677-0dab-f791-ed3039f26a93@redhat.com> Date: Mon, 18 Dec 2017 17:13:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <854645993.27733836.1513612982078.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 18 Dec 2017 16:13:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 29 > >>> + nested_vmx_disable_intercept_for_msr( >>> + msr_bitmap_l1, msr_bitmap_l0, >>> + APIC_BASE_MSR + (APIC_TASKPRI >> 4), >>> + MSR_TYPE_W); >> >> I'd vote for indenting the parameters properly (even though we exceed 80 >> chars by 1 then :) ) > > Ok, will do. Regarding the WARN, I'm undecided. I like the idea of not > calling a function that works on MSR bitmaps unless you have one... At least from a point of documentation it should be fine: "return false to indicate that we do not use the hardware" +gcc will inline this either way. > > Paolo > -- Thanks, David / dhildenb