Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936740AbdLRQok (ORCPT <rfc822;w@1wt.eu>);
        Mon, 18 Dec 2017 11:44:40 -0500
Received: from mx1.redhat.com ([209.132.183.28]:12677 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S936057AbdLRQof (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 18 Dec 2017 11:44:35 -0500
Date: Mon, 18 Dec 2017 14:44:31 -0200
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Stephane Eranian <eranian@google.com>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Andi Kleen <ak@linux.intel.com>,
        acme@kernel.org
Subject: Re: perf record: regression with latest PT fix
Message-ID: <20171218164431.GE2777@redhat.com>
References: <CABPqkBS10uwjVE+_OyYg0mVM8hbhxU9Jr9eBEFF8KQd_3j4SnQ@mail.gmail.com>
 <20171218132821.5gqxtwotgxvpqzy7@ukko.fi.intel.com>
 <f2ba3aeb-269d-8137-f7b8-13a658bff400@intel.com>
 <CANLsYkzPHqT-ue=Ew9zy0X1RWfjZD2Wy=2XaD4AmzkxMDotYwg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANLsYkzPHqT-ue=Ew9zy0X1RWfjZD2Wy=2XaD4AmzkxMDotYwg@mail.gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 18 Dec 2017 16:44:35 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1457
Lines: 48

Em Mon, Dec 18, 2017 at 08:23:46AM -0700, Mathieu Poirier escreveu:
> On 18 December 2017 at 07:25, Adrian Hunter <adrian.hunter@intel.com> wrote:
> > On 18/12/17 15:28, Alexander Shishkin wrote:
> >> On Mon, Dec 18, 2017 at 05:03:53AM -0800, Stephane Eranian wrote:
> >>> Hi,
> >>>
> >>>
> >>> The following patch:
> >>>
> >>> f785657b0fbe perf report: Fix regression when decoding Intel-PT traces
> >>
> >> Cc'ing Adrian in case he missed the patch.
> >
> > Doesn't seem to have much to do with Intel PT, but the patch logic looks wrong:
> >
> >                 ret = perf_evlist__parse_sample_timestamp(evlist, event, &timestamp);
> > -               if (ret)
> > +               if (ret != -1)
> >                         return ret;
> >
> > Shouldn't that be:
> >
> >                 ret = perf_evlist__parse_sample_timestamp(evlist, event, &timestamp);
> > -               if (ret)
> > +               if (ret && ret != -1)
> >                         return ret;
> 
> Of course!
> 
> Ingo, how do you want to proceed?  Should I send a V3?

Probably, I've run into this as well, as has Ingo, after I reverted it,
things got back working.

Back to vacations... :-)

- Arnaldo
 
> >>> is breaking perf report for me. I get no samples reported from perf report
> >>> when running simple perf record commands:
> >>>
> >>> $ perf record -e cycles noploop
> >>>
> >>> Reverting the patch fixes the problem.
> >>>
> >>> Are you seeing this as well?
> >>
> >