Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965163AbdLRQqM convert rfc822-to-8bit (ORCPT ); Mon, 18 Dec 2017 11:46:12 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:58169 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964860AbdLRQqI (ORCPT ); Mon, 18 Dec 2017 11:46:08 -0500 From: Gregory CLEMENT To: Mathieu Malaterre Cc: Andrew Lunn , Rob Herring , Jason Cooper , Sebastian Hesselbarth , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm: kirkwood: dts: Use lower case for bindings notation References: <20171215124653.30902-1-malat@debian.org> <20171215170711.8212-1-malat@debian.org> <20171215214354.GA31157@lunn.ch> Date: Mon, 18 Dec 2017 17:45:56 +0100 In-Reply-To: <20171215214354.GA31157@lunn.ch> (Andrew Lunn's message of "Fri, 15 Dec 2017 22:43:54 +0100") Message-ID: <871sjshtmj.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 45 Hi Mathieu, On ven., déc. 15 2017, Andrew Lunn wrote: > On Fri, Dec 15, 2017 at 06:07:11PM +0100, Mathieu Malaterre wrote: >> Improve the DTS files using lower case to fix the following dtc warnings: >> >> Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" >> >> Converted using the following command: >> >> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C >> >> For simplicity, two sed expressions were used to solve each warnings separately. >> >> To make the regex expression more robust a few other issues were resolved, >> namely setting unit-address to lower case, and adding a whitespace before the >> the opening curly brace: >> >> https://elinux.org/Device_Tree_Linux#Linux_conventions >> >> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") >> >> Reported-by: David Daney >> Suggested-by: Rob Herring >> Signed-off-by: Mathieu Malaterre > > Thanks for fixing up the commit message. > > Reviewed-by: Andrew Lunn Applied on mvebu/dt Thanks, Gregory > > Andrew -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com