Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935112AbdLRReW (ORCPT ); Mon, 18 Dec 2017 12:34:22 -0500 Received: from mx2.suse.de ([195.135.220.15]:46157 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934696AbdLRReQ (ORCPT ); Mon, 18 Dec 2017 12:34:16 -0500 Date: Mon, 18 Dec 2017 18:34:13 +0100 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Randy Dunlap Cc: Hari Bathini , linuxppc-dev , Andrew Morton , Ankit Kumar , lkml , Mahesh J Salgaonkar Subject: Re: [PATCH] Fix parse_args cycle limit check. Message-ID: <20171218183413.53358649@kitsune.suse.cz> In-Reply-To: <12296c9b-d215-20d4-843e-4c9c9c06f0be@infradead.org> References: <20171215214702.7c7afba1@kitsune.suse.cz> <20171215214149.3692-1-msuchanek@suse.de> <12296c9b-d215-20d4-843e-4c9c9c06f0be@infradead.org> Organization: SUSE Linux X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 25 On Fri, 15 Dec 2017 15:49:09 -0800 Randy Dunlap wrote: > On 12/15/2017 01:41 PM, Michal Suchanek wrote: > > Actually args are supposed to be renamed to next so both and args > > hold the previous argument so both can be passed to the callback. > > This additionla patch > > additional > > > should fix up the rename. > > Would you try rewriting the first sentence, please? I don't get it. Ok, I guess this should be clarified. For the original patch and the fixup squashed together this is what the patch is supposed to do: This patch adds variable for tracking the parameter which is currently being processed. There is "args" variable which tracks the parameter which will be processed next so this patch adds "next" variable to track that and uses "args" to track the current argument. Thanks Michal