From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "joe@perches.com" <joe@perches.com>, "jgg@ziepe.ca" <jgg@ziepe.ca>
CC: "corbet@lwn.net" <corbet@lwn.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "willy@infradead.org" <willy@infradead.org>,
        "knut.omang@oracle.com" <knut.omang@oracle.com>,
        "nicolas.palix@imag.fr" <nicolas.palix@imag.fr>,
        "asmund.ostvold@oracle.com" <asmund.ostvold@oracle.com>,
        "john.haxby@oracle.com" <john.haxby@oracle.com>,
        "alexander.levin@verizon.com" <alexander.levin@verizon.com>,
        "mchehab@kernel.org" <mchehab@kernel.org>,
        "haakon.bugge@oracle.com" <haakon.bugge@oracle.com>,
        "michal.lkml@markovi.net" <michal.lkml@markovi.net>,
        "Gilles.Muller@lip6.fr" <Gilles.Muller@lip6.fr>,
        "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
        "mic@digikod.net" <mic@digikod.net>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
        "rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
        "Julia.Lawall@lip6.fr" <Julia.Lawall@lip6.fr>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "stephen@networkplumber.org" <stephen@networkplumber.org>,
        "cocci@systeme.lip6.fr" <cocci@systeme.lip6.fr>,
        "dledford@redhat.com" <dledford@redhat.com>,
        "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>,
        "apw@canonical.com" <apw@canonical.com>
Subject: Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a
 wrapper program
Thread-Topic: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a
 wrapper program
Thread-Index: AQHTdnxs/xsAJCRkCUqNJHDBnmmVDqNGPvyAgACNfgCAAcDdgIAAEKSAgADFMgCAAAMIgA==
Date: Mon, 18 Dec 2017 17:56:57 +0000
Message-ID: <1513619815.2798.2.camel@wdc.com>
References: <cover.630ac8faeeda67bf7a778c158174422042942d08.1513430008.git-series.knut.omang@oracle.com>
         <20171216094745.5e41ac51@xeon-e3> <1513476850.31439.108.camel@oracle.com>
         <20171218050043.GA1307@ziepe.ca> <1513576817.31581.58.camel@perches.com>
         <20171218174604.GA19056@ziepe.ca>
In-Reply-To: <20171218174604.GA19056@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <5B34137F6E43E048AB6974A87AAEB18E@namprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ae68ec5-16ac-4a6d-0909-08d54640bb64
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2017 17:56:57.4008
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1534
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vBIHvHXT016423
Content-Length: 1168
Lines: 29

On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote:
> On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote:
> 
> > > Today when we run checkers we get so many warnings it is too hard to
> > > make any sense of it.
> > 
> > Here is a list of the checkpatch messages for drivers/infiniband
> > sorted by type.
> > 
> > Many of these might be corrected by using
> > 
> > $ ./scripts/checkpatch.pl -f --fix-inplace --types=<TYPE> \
> >   $(git ls-files drivers/infiniband/)
> 
> How many of these do you think it is worth to fix?
> 
> We do get a steady trickle of changes in this topic every cycle.
> 
> Is it better to just do a big number of them all at once? Do you have
> an idea how disruptive this kind of work is to the whole patch flow
> eg new patches no longer applying to for-next, backports no longer
> applying, merge conflicts?

In my opinion patches that only change the coding style and do not change any
functionality are annoying. Before posting a patch that fixes a bug the change
history (git log -p) has to be cheched to figure out which patch introduced
the bug. Patches that only change coding style pollute the change history.

Bart.