Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936995AbdLRSIj convert rfc822-to-8bit (ORCPT ); Mon, 18 Dec 2017 13:08:39 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:32837 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933871AbdLRSIf (ORCPT ); Mon, 18 Dec 2017 13:08:35 -0500 X-Google-Smtp-Source: ACJfBouTrLoQaQlQEFbC2A3v1q5HnOpu2H2rzJSRS9sUwU0Q749Hl1ceoN9/6+6+CVnzpPZDVnq+hA== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e From: Kai-Heng Feng In-Reply-To: <20171218160454.3895-1-dmitry.fleytman@gmail.com> Date: Tue, 19 Dec 2017 02:07:46 +0800 Cc: Greg Kroah-Hartman , Felipe Balbi , Alan Stern , Dmitry Fleytman , =?utf-8?B?THVrw6HFoSBMYWxpbnNrw70=?= , Daniel Drake , Samuel Thibault , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <4B8F85D4-C35F-4B36-8196-5F51DA24422F@canonical.com> References: <20171218160454.3895-1-dmitry.fleytman@gmail.com> To: Dmitry Fleytman X-Mailer: Apple Mail (2.3445.5.20) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 45 Hi, > On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman wrote: > > From: Dmitry Fleytman Dmitry Fleytman > > Commit e0429362ab15 > ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") > introduced quirk to workaround an issue with some Logitech webcams. > > There is one more model that has the same issue - C925e, so applying > the same quirk as well. > > See aforementioned commit message for detailed explanation of the problem. > > Signed-off-by: Dmitry Fleytman > --- > drivers/usb/core/quirks.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index a10b346b9777..6d2d3b0bcc2a 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = { > /* Microsoft LifeCam-VX700 v2.0 */ > { USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME }, > > - /* Logitech HD Pro Webcams C920, C920-C and C930e */ > + /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */ > { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT }, > { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT }, > { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT }, > + { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT }, Nitpicking here, but maybe use 0x085b instead of 0x085B? Kai-Heng > > /* Logitech ConferenceCam CC3000e */ > { USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT }, > -- > 2.14.1 >