Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934602AbdLRSWs (ORCPT ); Mon, 18 Dec 2017 13:22:48 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:58311 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933294AbdLRSW2 (ORCPT ); Mon, 18 Dec 2017 13:22:28 -0500 Subject: Re: [PATCH 2/2] ps3: Improve a size determination in five functions To: SF Markus Elfring , linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Cc: LKML , kernel-janitors@vger.kernel.org References: <9b6464bc-a408-de2a-1b54-cb7794b92506@users.sourceforge.net> <7aed1208-aa55-edb6-54be-f47fb1498bfd@users.sourceforge.net> From: Geoff Levand Message-ID: <128a40fe-0998-2d6c-ad56-e7b63fce7f12@infradead.org> Date: Mon, 18 Dec 2017 10:22:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <7aed1208-aa55-edb6-54be-f47fb1498bfd@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 529 Lines: 16 Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. This would be OK, but you are also removing empty lines and changing the coding format. Please update the patch to only make the sizeof changes. -Geoff