Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759592AbdLRSo0 (ORCPT ); Mon, 18 Dec 2017 13:44:26 -0500 Received: from canardo.mork.no ([148.122.252.1]:56939 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758595AbdLRSoW (ORCPT ); Mon, 18 Dec 2017 13:44:22 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: SZ Lin Cc: Johan Hovold , Taiyi Wu , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5 Organization: m References: <20171215103203.2579-1-sz.lin@moxa.com> <20171218165248.GF3374@localhost> Date: Mon, 18 Dec 2017 19:44:07 +0100 In-Reply-To: <20171218165248.GF3374@localhost> (Johan Hovold's message of "Mon, 18 Dec 2017 17:52:48 +0100") Message-ID: <87lghzc1vs.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBIIiWh9030969 Content-Length: 658 Lines: 19 Johan Hovold writes: >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> + .reserved = BIT(0) | BIT(1) | BIT(4), >> +}; > > Do you really need to blacklist the first interface? Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG function, based on two bulk endpoints, no additional descriptors and the fact that it is the first interface. If so, then we do want a serial driver for it. There is a basic libqcdm implementation in ModemManager if you want to test it out. And I expect interface #4 is QMI/rmnet? Feel free to confirm that assumption with a patch against qmi_wwan :-) Bjørn