Message-ID: <1513625246.3434.0.camel@gmail.com>
Subject: Re: [PATCH] Staging: irda: Do not check for NOT NULL before kfree()
From: Shreeya Patel <shreeya.patel23498@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: samuel@sortiz.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Tue, 19 Dec 2017 00:57:26 +0530
In-Reply-To: <20171218112038.15626e20@xeon-e3>
References: <1513624290-2965-1-git-send-email-shreeya.patel23498@gmail.com>
         <20171218112038.15626e20@xeon-e3>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 719
Lines: 28

On Mon, 2017-12-18 at 11:20 -0800, Stephen Hemminger wrote:
> On Tue, 19 Dec 2017 00:41:30 +0530
> Shreeya Patel <shreeya.patel23498@gmail.com> wrote:
> 
> > 
> > Do not check for NOT NULL before calling kfree because if the
> > pointer is NULL, no action occurs.
> > Done using the following semantic patch by coccinelle.
> > 
> > @@
> > expression ptr;
> > @@
> > 
> > - if (ptr != NULL) {
> >   kfree(ptr);
> >   ptr = NULL;
> > - }
> > 
> > The semantic patch has the effect of adding an assignment
> > of ptr to NULL in the case where ptr is NULL already.
> > 
> > Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> Please read drivers/staging/irda/TODO

Oh, I was not knowing about it.

Thank you
>