Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757754AbdLRTuf (ORCPT ); Mon, 18 Dec 2017 14:50:35 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:40140 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750773AbdLRTub (ORCPT ); Mon, 18 Dec 2017 14:50:31 -0500 Date: Mon, 18 Dec 2017 14:50:29 -0500 (EST) Message-Id: <20171218.145029.1566604436298914194.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH net-next] net/ncsi: Don't take any action on HNCDSC AEN From: David Miller In-Reply-To: <20171215051640.10926-1-sam@mendozajonas.com> References: <20171215051640.10926-1-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 18 Dec 2017 11:50:30 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 19 From: Samuel Mendoza-Jonas Date: Fri, 15 Dec 2017 16:16:40 +1100 > The current HNCDSC handler takes the status flag from the AEN packet and > will update or change the current channel based on this flag and the > current channel status. > > However the flag from the HNCDSC packet merely represents the host link > state. While the state of the host interface is potentially interesting > information it should not affect the state of the NCSI link. Indeed the > NCSI specification makes no mention of any recommended action related to > the host network controller driver state. > > Update the HNCDSC handler to record the host network driver status but > take no other action. > > Signed-off-by: Samuel Mendoza-Jonas Applied, thanks.