Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933701AbdLRUDt (ORCPT ); Mon, 18 Dec 2017 15:03:49 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:34337 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933343AbdLRUDp (ORCPT ); Mon, 18 Dec 2017 15:03:45 -0500 Date: Mon, 18 Dec 2017 21:03:32 +0100 From: Boris Brezillon To: Christophe JAILLET Cc: kyungmin.park@samsung.com, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/4 v3] mtd: onenand: samsung: Simplify code and fix leaks in error handling paths Message-ID: <20171218210332.4fd91ec3@bbrezillon> In-Reply-To: References: X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 42 On Thu, 14 Dec 2017 07:03:48 +0100 Christophe JAILLET wrote: > The first patch converts 's3c_onenand_probe()' to devm_ functions. > This fixes a leak in one path (line 872). > This also free_irq which was not handled at all. ( I hope I'm correct :) ) > > The 2nd patch is about an un-handled error code which looks spurious. > Not sure if I'm right. > > The 3rd patch propagates an error code instead of returning a hard-coded > value. > > The last one removes a useless include spotted while compile-testing. > > > v3: patch 1/4 updated to fix a bug introduced in v2 > patch 2/4 unchanged > patch 3/4 and 4/4 added > now the patch are cross-compile tested :) > > Theses patches have been cross compile-tested-only. Applied the whole series. Thanks, Boris > > Christophe JAILLET (4): > mtd: onenand: samsung: use devm_ function to simplify > code and fix some leaks > mtd: onenand: samsung: return an error if > 'mtd_device_parse_register()' fails > mtd: onenand: samsung: Propagate the error returned > by 'onenand_scan()' > mtd: onenand: samsung: Remove a useless include > > drivers/mtd/onenand/samsung.c | 172 +++++++++--------------------------------- > 1 file changed, 35 insertions(+), 137 deletions(-) >