Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932927AbdLRUTN (ORCPT ); Mon, 18 Dec 2017 15:19:13 -0500 Received: from mail-wr0-f170.google.com ([209.85.128.170]:41694 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933173AbdLRUTI (ORCPT ); Mon, 18 Dec 2017 15:19:08 -0500 X-Google-Smtp-Source: ACJfBovoDIgXDqnudsljhl7rHjGu6iir5ppTz0rR/Fsa7rBYgYdSVfWgTrDutNBjwiRifP66w4u1Kg== Date: Mon, 18 Dec 2017 13:19:02 -0700 From: Jason Gunthorpe To: "Shaikh, Azhar" Cc: Javier Martinez Canillas , Jarkko Sakkinen , James Ettle , "linux-integrity@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "james.l.morris@oracle.com" Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system Message-ID: <20171218201902.GF19056@ziepe.ca> References: <011b4d29-9d93-4b7a-90dd-0c25cf184c3e@redhat.com> <20171214191052.GA20833@ziepe.ca> <20171215145630.ftsnj4azqqhzqwsh@linux.intel.com> <20171215173826.GD12434@ziepe.ca> <1513443676.29063.0.camel@linux.intel.com> <16609e73-e35d-4bb0-410d-e87915daba39@redhat.com> <20171218175502.GC19056@ziepe.ca> <379b4165-bf82-70e9-4fc9-018fb62ee23c@redhat.com> <5FFFAD06ADE1CA4381B3F0F7C6AF5828987F13@ORSMSX109.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5FFFAD06ADE1CA4381B3F0F7C6AF5828987F13@ORSMSX109.amr.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 579 Lines: 16 On Mon, Dec 18, 2017 at 07:34:29PM +0000, Shaikh, Azhar wrote: > >IIUC, if CLKRUN_EN is enabled, then all the devices attached to the > >LPC bus have to support the CLKRUN protocol. My guess is that on > >some Braswell systems LPC power management is enabled but the TPM > >device doesn't have CLKRUN support. > > I think this is what might be happening here. That makes it a BIOS bug, not a chipset bug, and we shouldn't be trying to fix it like this in Linux. Based on the original discussion I always thought this was an Intel chipset bug and applies to all cases. Jason