Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933688AbdLRUYy (ORCPT ); Mon, 18 Dec 2017 15:24:54 -0500 Received: from mail-ot0-f194.google.com ([74.125.82.194]:36866 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933233AbdLRUYq (ORCPT ); Mon, 18 Dec 2017 15:24:46 -0500 X-Google-Smtp-Source: ACJfBotPQafrMN2EKCj/G5KlArsMy7tI1S6n6CXqPLit4Ct+Baz+3WWm6L7pOjvGjF1rz0jGzBgyeok3VNpU4ekmUBU= MIME-Version: 1.0 In-Reply-To: <1513610272-7824-4-git-send-email-ludovic.Barre@st.com> References: <1513610272-7824-1-git-send-email-ludovic.Barre@st.com> <1513610272-7824-4-git-send-email-ludovic.Barre@st.com> From: Arnd Bergmann Date: Mon, 18 Dec 2017 21:24:45 +0100 X-Google-Sender-Auth: WcRS5muwcoWYof-tShGKpz4wfGo Message-ID: Subject: Re: [PATCH V2 3/9] ARM: stm32: prepare stm32 family to welcome armv7 architecture To: Ludovic Barre Cc: Russell King , Rob Herring , Linus Walleij , Maxime Coquelin , Alexandre Torgue , Gerald Baeza , Linux ARM , Linux Kernel Mailing List , DTML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1792 Lines: 47 On Mon, Dec 18, 2017 at 4:17 PM, Ludovic Barre wrote: > From: Ludovic Barre > > This patch prepares the STM32 machine for the integration of Cortex-A > based microprocessor (MPU), on top of the existing Cortex-M > microcontroller family (MCU). Since both MCUs and MPUs are sharing > common hardware blocks we can keep using ARCH_STM32 flag for most of > them. If a hardware block is specific to one family we can use either > ARM_SINGLE_ARMV7M or ARCH_MULTI_V7 flag. > > Signed-off-by: Ludovic Barre Looks good overall. Two more small comments: > > +if ARCH_STM32 > + > config MACH_STM32F429 > - bool "STMicrolectronics STM32F429" > - depends on ARCH_STM32 > + bool "STMicroelectronics STM32F429" > + depends on ARM_SINGLE_ARMV7M > default y Instead of the explicit dependency for each board, I'd leave the surrounding 'if ARM_SINGLE_ARMV7M'. I think you had in v1. > diff --git a/arch/arm/mach-stm32/Makefile b/arch/arm/mach-stm32/Makefile > index bd0b7b5..5940af1 100644 > --- a/arch/arm/mach-stm32/Makefile > +++ b/arch/arm/mach-stm32/Makefile > @@ -1 +1 @@ > -obj-y += board-dt.o > +obj-$(CONFIG_ARM_SINGLE_ARMV7M) += board-mcu-dt.o > diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-mcu-dt.c > similarity index 100% > rename from arch/arm/mach-stm32/board-dt.c > rename to arch/arm/mach-stm32/board-mcu-dt.c Why the rename? I don't expect the new machines to have any notable contents in a board file, if any at all, so just use one file for both. I see the board-dt.c file refers to armv7m_restart, we can either put that in an #ifdef, or find a way to make it the default for all armv7-m platforms that don't provide any other restart method. Arnd