Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760583AbdLRUld (ORCPT ); Mon, 18 Dec 2017 15:41:33 -0500 Received: from mx2.suse.de ([195.135.220.15]:59961 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759565AbdLRUl1 (ORCPT ); Mon, 18 Dec 2017 15:41:27 -0500 Date: Mon, 18 Dec 2017 21:41:25 +0100 From: Michal Hocko To: Andrei Vagin Cc: linux-kernel@vger.kernel.org, Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] mm: don't use the same value for MAP_FIXED_SAFE and MAP_SYNC Message-ID: <20171218204052.GR16951@dhcp22.suse.cz> References: <20171218091302.GL16951@dhcp22.suse.cz> <20171218184916.24445-1-avagin@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171218184916.24445-1-avagin@openvz.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 27 On Mon 18-12-17 10:49:16, Andrei Vagin wrote: > Cc: Michal Hocko > Fixes: ("fs, elf: drop MAP_FIXED usage from elf_map") > Signed-off-by: Andrei Vagin > --- > include/uapi/asm-generic/mman-common.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/asm-generic/mman-common.h b/include/uapi/asm-generic/mman-common.h > index b37502cbbef7..2db3fa287274 100644 > --- a/include/uapi/asm-generic/mman-common.h > +++ b/include/uapi/asm-generic/mman-common.h > @@ -26,7 +26,9 @@ > #else > # define MAP_UNINITIALIZED 0x0 /* Don't support this flag */ > #endif > -#define MAP_FIXED_SAFE 0x80000 /* MAP_FIXED which doesn't unmap underlying mapping */ > + > +/* 0x0100 - 0x80000 flags are defined in asm-generic/mman.h */ > +#define MAP_FIXED_SAFE 0x100000 /* MAP_FIXED which doesn't unmap underlying mapping */ Ouch, I was developing on top of mmotm which didn't have the new the new MAP_SYNC. Thanks for catching that. Andrew, could you fold this into the patch, please? -- Michal Hocko SUSE Labs