From: Patrick Farrell <paf@cray.com>
To: NeilBrown <neilb@suse.com>, Oleg Drokin <oleg.drokin@intel.com>,
        "Andreas Dilger" <andreas.dilger@intel.com>,
        James Simmons <jsimmons@infradead.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: lkml <linux-kernel@vger.kernel.org>,
        lustre <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH 08/16] staging: lustre: open code polling
 loop instead of using l_wait_event()
Thread-Topic: [lustre-devel] [PATCH 08/16] staging: lustre: open code polling
 loop instead of using l_wait_event()
Thread-Index: AQHTd9CY1aN89v6yd0qdfVlY8OHOd6NJMMGA
Date: Mon, 18 Dec 2017 20:55:10 +0000
Message-ID: <D65D86E7.C5E12%paf@cray.com>
References: <151358127190.5099.12792810096274074963.stgit@noble>
 <151358148008.5099.7316878897181140635.stgit@noble>
In-Reply-To: <151358148008.5099.7316878897181140635.stgit@noble>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.7.2.170228
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <97575341CE174641A33D086E1846DE88@namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0257dac9-1df8-43a1-8907-08d54659a0d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2017 20:55:10.5613
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e7b8488a-c0cd-4614-aae1-996bfabec247
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2141
X-OriginatorOrg: cray.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBIKtLCc021666
Content-Length: 3084
Lines: 89

The lov_check_and_wait_active wait is usually (always?) going to be
asynchronous from userspace and probably shouldn?t contribute to load.

So I guess that means schedule_timeout_idle.

On 12/18/17, 1:18 AM, "lustre-devel on behalf of NeilBrown"
<lustre-devel-bounces@lists.lustre.org on behalf of neilb@suse.com> wrote:

>Two places that LWI_TIMEOUT_INTERVAL() is used, the outcome is a
>simple polling loop that polls every second for some event (with a
>limit).
>
>So write a simple loop to make this more apparent.
>
>Signed-off-by: NeilBrown <neilb@suse.com>
>---
> drivers/staging/lustre/lustre/llite/llite_lib.c |   11 +++++------
> drivers/staging/lustre/lustre/lov/lov_request.c |   12 +++++-------
> 2 files changed, 10 insertions(+), 13 deletions(-)
>
>diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c
>b/drivers/staging/lustre/lustre/llite/llite_lib.c
>index 33dc15e9aebb..f6642fa30428 100644
>--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
>+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
>@@ -1984,8 +1984,7 @@ void ll_umount_begin(struct super_block *sb)
> 	struct ll_sb_info *sbi = ll_s2sbi(sb);
> 	struct obd_device *obd;
> 	struct obd_ioctl_data *ioc_data;
>-	wait_queue_head_t waitq;
>-	struct l_wait_info lwi;
>+	int cnt = 0;
> 
> 	CDEBUG(D_VFSTRACE, "VFS Op: superblock %p count %d active %d\n", sb,
> 	       sb->s_count, atomic_read(&sb->s_active));
>@@ -2021,10 +2020,10 @@ void ll_umount_begin(struct super_block *sb)
> 	 * and then continue. For now, we just periodically checking for vfs
> 	 * to decrement mnt_cnt and hope to finish it within 10sec.
> 	 */
>-	init_waitqueue_head(&waitq);
>-	lwi = LWI_TIMEOUT_INTERVAL(10 * HZ,
>-				   HZ, NULL, NULL);
>-	l_wait_event(waitq, may_umount(sbi->ll_mnt.mnt), &lwi);
>+	while (cnt < 10 && !may_umount(sbi->ll_mnt.mnt)) {
>+		schedule_timeout_uninterruptible(HZ);
>+		cnt ++;
>+	}
> 
> 	schedule();
> }
>diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c
>b/drivers/staging/lustre/lustre/lov/lov_request.c
>index fb3b7a7fa32a..c1e58fcc30b3 100644
>--- a/drivers/staging/lustre/lustre/lov/lov_request.c
>+++ b/drivers/staging/lustre/lustre/lov/lov_request.c
>@@ -99,8 +99,7 @@ static int lov_check_set(struct lov_obd *lov, int idx)
>  */
> static int lov_check_and_wait_active(struct lov_obd *lov, int ost_idx)
> {
>-	wait_queue_head_t waitq;
>-	struct l_wait_info lwi;
>+	int cnt = 0;
> 	struct lov_tgt_desc *tgt;
> 	int rc = 0;
> 
>@@ -125,11 +124,10 @@ static int lov_check_and_wait_active(struct lov_obd
>*lov, int ost_idx)
> 
> 	mutex_unlock(&lov->lov_lock);
> 
>-	init_waitqueue_head(&waitq);
>-	lwi = LWI_TIMEOUT_INTERVAL(obd_timeout * HZ,
>-				   HZ, NULL, NULL);
>-
>-	rc = l_wait_event(waitq, lov_check_set(lov, ost_idx), &lwi);
>+	while (cnt < obd_timeout && !lov_check_set(lov, ost_idx)) {
>+		schedule_timeout_uninterruptible(HZ);
>+		cnt ++;
>+	}
> 	if (tgt->ltd_active)
> 		return 1;
> 
>
>
>_______________________________________________
>lustre-devel mailing list
>lustre-devel@lists.lustre.org
>http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org