Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935241AbdLRVcg (ORCPT ); Mon, 18 Dec 2017 16:32:36 -0500 Received: from mout.web.de ([212.227.17.11]:50416 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934777AbdLRVce (ORCPT ); Mon, 18 Dec 2017 16:32:34 -0500 Subject: [PATCH 2/2] platform/x86/thinkpad_acpi: Improve a size determination in tpacpi_new_rfkill() From: SF Markus Elfring To: ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, Andy Shevchenko , Darren Hart , Henrique de Moraes Holschuh Cc: LKML , kernel-janitors@vger.kernel.org References: <81459d11-693a-eb51-9173-9c189677f422@users.sourceforge.net> Message-ID: <36da9194-4254-91ef-5b82-ab150801b911@users.sourceforge.net> Date: Mon, 18 Dec 2017 22:30:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <81459d11-693a-eb51-9173-9c189677f422@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:hiCV68xb6rsRI5mGnwutFI/WfhPa2D5Ndmm1VHpnzyBl4mKb7F9 FqVW+/4kpmdt1yE3FTREnE6mEnGXr6LscCFb49kb4SDzthmdjZwporikyMsY/hetT9m3vwf LJH13s3Lb2hwT7eLe0dbm7EVkK9J+wIM+4pRdqQ0QVBg/HUKvjTu7GqIN3W/5zv3oNnGi8B ZHmg4FVUrnHbwD/d8T9qg== X-UI-Out-Filterresults: notjunk:1;V01:K0:SgAXeBjbo6g=:7CYLAqlmb2dqKF+CH8gGyR iXvGTeOEQ4taOsy1pXdwwrKGCtjLEss4+LwIDWkboe0Uu2ejd/TmRvlumISunXfeFx+4iVVKq ezGwVmi1XNjk/xuzZ+HaFh7Q1kY5dbl3B3Uawsd0UL4uBNQskAA4kYy2GztToq7aeY4+n8E1f 7MsG1ui/SMiPq0OSW5LWwfdhROyJZxnM2ZZAbMt5jCUsN5AqMVsxfJMEgOGqKAqSgItsZYwLS q5YA1VglHu0qsPQd5Rwzz4QpkIB2hlrypMJmICf+PUnDkfUCxo1W1ZAlLUOBfEFmsSJ0FSUH9 zkgb6R3hWfWZJthV5Sc9HFzQ2rWI6S+9kqfcNzoxeCCNpzfqIepSXm1BTYixOGyt6cb9HGaQu n5t4qgIInchVdT66szwL9HGEQKb9PELYBveSk82QXxKubl2o5P7HlorWMrlWZhP6aHLTz4nid BrbyzZ66cR2s7zzQpwhtaVJj4WW6Cs39x0T+1x0/mZ4ImWxlWrvt/PoUhBf9chzVaLtOOLxpk Qd9uvWs7aCco9yTEJrEmGCWJwWyKwwy/dQk4O1+THyP6cg54iBuoGXdgxlm8K9Nj2yBNtaIjY U1r/rszWOw19OK42WXyCLImi4MbNaAKpRATI99EiqrYrj+CpIM85AU/0MjjkmeYn86xgtBV6/ iKYoT+L0PXgWi0lgEz+LRsQvMt2L+17K7Dz0T9BotJceKFKxeNXbM+36i5Od2BuV0GXtQb1dw yXA8LwJ8AHthE96cNtlOKZL0QY6Q/L9oQQ5QQb6h13OBG4a1zFxsxbTlDgYWcPT1XeR2usLm+ EW6fVEET3RcMWxZOUHnWx1pO+WI1V6VS4NFu9dtwYVjdbkN7eI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1104 Lines: 29 From: Markus Elfring Date: Mon, 18 Dec 2017 22:13:53 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 729144925880..40b7a1b9a019 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -1258,7 +1258,7 @@ static int __init tpacpi_new_rfkill(const enum tpacpi_rfk_id id, BUG_ON(id >= TPACPI_RFK_SW_MAX || tpacpi_rfkill_switches[id]); - atp_rfk = kzalloc(sizeof(struct tpacpi_rfk), GFP_KERNEL); + atp_rfk = kzalloc(sizeof(*atp_rfk), GFP_KERNEL); if (atp_rfk) atp_rfk->rfkill = rfkill_alloc(name, &tpacpi_pdev->dev, -- 2.15.1