Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965293AbdLRXrR (ORCPT ); Mon, 18 Dec 2017 18:47:17 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:37326 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965172AbdLRXrM (ORCPT ); Mon, 18 Dec 2017 18:47:12 -0500 Subject: Re: [PATCH 11/13] cxl: Remove support for "Processing accelerators" class To: Frederic Barrat , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: arnd@arndb.de, gregkh@linuxfoundation.org, mpe@ellerman.id.au, alastair@au1.ibm.com References: <199cdb186d837daa838a37d937c6586bb9cfe1a2.1513608243.git.fbarrat@linux.vnet.ibm.com> From: Andrew Donnellan Date: Tue, 19 Dec 2017 10:47:04 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <199cdb186d837daa838a37d937c6586bb9cfe1a2.1513608243.git.fbarrat@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17121823-0012-0000-0000-0000059A800D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17121823-0013-0000-0000-00001915A78F Message-Id: <05f705cc-588c-58ea-27e2-8a992c62b298@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-18_17:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712180310 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1467 Lines: 38 On 19/12/17 02:21, Frederic Barrat wrote: > The cxl driver currently declares in its table of supported PCI > devices the class "Processing accelerators". Therefore it may be > called to probe for opencapi devices, which generates errors, as the > config space of a cxl device is not compatible with opencapi. > > So remove support for the generic class, as we now have (at least) two > drivers for devices of the same class. Most cxl devices are FPGAs with > a PSL which will show a known device ID of 0x477. Other devices are > really supported by the cxlflash driver and are already listed in the > table. So removing the class is expected to go unnoticed. > > Signed-off-by: Frederic Barrat Acked-by: Andrew Donnellan > --- > drivers/misc/cxl/pci.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/misc/cxl/pci.c b/drivers/misc/cxl/pci.c > index 19969ee86d6f..758842f65a1b 100644 > --- a/drivers/misc/cxl/pci.c > +++ b/drivers/misc/cxl/pci.c > @@ -125,8 +125,6 @@ static const struct pci_device_id cxl_pci_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0601), }, > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0623), }, > { PCI_DEVICE(PCI_VENDOR_ID_IBM, 0x0628), }, > - { PCI_DEVICE_CLASS(0x120000, ~0), }, > - > { } > }; > MODULE_DEVICE_TABLE(pci, cxl_pci_tbl); > -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited