Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760708AbdLSA0S (ORCPT ); Mon, 18 Dec 2017 19:26:18 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:46918 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760674AbdLSA0J (ORCPT ); Mon, 18 Dec 2017 19:26:09 -0500 X-Google-Smtp-Source: ACJfBosSY1zl9pwJgs28xr8T7OpCAhJyt9dC6R6BNOr/vGXDiaWhGq/+w1M490hg5VcTWBWDegRMpw== Subject: Re: [PATCH v.2] 4.15 vmgfx boot warning From: Woody Suwalski To: Daniel Vetter Cc: Sinclair Yeh , DRI mailing list , LKML , Dave Airlie References: <20171213212522.GC16788@promb-2n-dhcp36.eng.vmware.com> <1d88409f-23c4-6706-7111-00f2d13f3351@gmail.com> Message-ID: <5508ddeb-ef4d-abfa-2573-717066448a43@gmail.com> Date: Mon, 18 Dec 2017 19:26:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 MIME-Version: 1.0 In-Reply-To: <1d88409f-23c4-6706-7111-00f2d13f3351@gmail.com> Content-Type: multipart/mixed; boundary="------------E2306E517B9C0E1D3FEB1B12" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1935 Lines: 54 This is a multi-part message in MIME format. --------------E2306E517B9C0E1D3FEB1B12 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit The 4.15 drm_atomic_helper driver shows a warning during boot (both 32 and 64 bit x86) It is caused by a mismatch between the result of vmw_enable_vblank() and what the drm_atomic_helper expects:    /...    ret = drm_crtc_vblank_get(crtc);    WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n");    /... Signed-off by: Woody Suwalski --- a/drivers/gpu/drm/drm_atomic_helper.c    2017-12-16 09:55:33.853374561 -0500 +++ b/drivers/gpu/drm/drm_atomic_helper.c    2017-12-16 10:55:56.089090752 -0500 @@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev,              continue;          ret = drm_crtc_vblank_get(crtc); -        WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n"); +        WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to call drm_crtc_vblank_off()\n");          if (ret == 0)              drm_crtc_vblank_put(crtc);      } --------------E2306E517B9C0E1D3FEB1B12 Content-Type: text/x-patch; name="040_drm_atomic_helper.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="040_drm_atomic_helper.patch" --- a/drivers/gpu/drm/drm_atomic_helper.c 2017-12-16 09:55:33.853374561 -0500 +++ b/drivers/gpu/drm/drm_atomic_helper.c 2017-12-16 10:55:56.089090752 -0500 @@ -889,7 +889,7 @@ disable_outputs(struct drm_device *dev, continue; ret = drm_crtc_vblank_get(crtc); - WARN_ONCE(ret != -EINVAL, "driver forgot to call drm_crtc_vblank_off()\n"); + WARN_ONCE((ret != -EINVAL && ret != -ENOSYS), "driver forgot to call drm_crtc_vblank_off()\n"); if (ret == 0) drm_crtc_vblank_put(crtc); } --------------E2306E517B9C0E1D3FEB1B12--