Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966043AbdLSA2Y (ORCPT ); Mon, 18 Dec 2017 19:28:24 -0500 Received: from www62.your-server.de ([213.133.104.62]:52239 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935250AbdLSA2U (ORCPT ); Mon, 18 Dec 2017 19:28:20 -0500 Subject: Re: [PATCH][next] bpf: make function skip_callee static and return NULL rather than 0 To: Colin King , Alexei Starovoitov , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171218174707.15430-1-colin.king@canonical.com> From: Daniel Borkmann Message-ID: <22724a21-5e99-dddb-31f1-ae8e1916d2ff@iogearbox.net> Date: Tue, 19 Dec 2017 01:28:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171218174707.15430-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 482 Lines: 13 On 12/18/2017 06:47 PM, Colin King wrote: > From: Colin Ian King > > Function skip_callee is local to the source and does not need to > be in global scope, so make it static. Also return NULL rather than 0. > Cleans up two sparse warnings: > > symbol 'skip_callee' was not declared. Should it be static? > Using plain integer as NULL pointer > > Signed-off-by: Colin Ian King Makes sense, applied to bpf-next, thanks Colin!