Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966262AbdLSBku (ORCPT ); Mon, 18 Dec 2017 20:40:50 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2693 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934723AbdLSBkq (ORCPT ); Mon, 18 Dec 2017 20:40:46 -0500 Subject: Re: [PATCH net-next 14/17] net: hns3: add Asym Pause support to phy default features To: Sergei Shtylyov , References: <1513589500-121623-1-git-send-email-lipeng321@huawei.com> <1513589500-121623-15-git-send-email-lipeng321@huawei.com> CC: , , , From: "lipeng (Y)" Message-ID: <3f3727be-5928-483a-52a2-1baacd8a30e7@huawei.com> Date: Tue, 19 Dec 2017 09:40:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.63.173.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 866 Lines: 40 On 2017/12/18 17:07, Sergei Shtylyov wrote: > Hello! > > On 12/18/2017 12:31 PM, Lipeng wrote: > >> From: Fuyun Liang >> >> commit c4fb2cdf575d (net: hns3: fix a bug for phy supported feature >> initialization) adds default supported features for phy, but our >> hardware > > Ten cited commit's summary needs to be enclosed in (""), not just > ()... > Thanks , will fix it. >> also supports Asym Pause. This patch adds Asym Pause support to phy >> default features to prevent Asym Pause can not be advertised when the >> phy >> negotiates flow control. >> >> Fixes: c4fb2cdf575d (net: hns3: fix a bug for phy supported feature >> initialization) > > Here as well... > will fix here too. Thanks >> Signed-off-by: Fuyun Liang >> Signed-off-by: Lipeng > [...] > > MBR, Sergei > >