Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937513AbdLSDw6 (ORCPT ); Mon, 18 Dec 2017 22:52:58 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:42730 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759421AbdLSDw4 (ORCPT ); Mon, 18 Dec 2017 22:52:56 -0500 X-Google-Smtp-Source: ACJfBotfm/EfXrhl6lnXt7Q7RDSskLjyyyQiYG9AIE0TX07M4N9+y2KtDyXfxeugHKamygh5LAS4+g== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: Re: [PATCH] usb: Add device quirk for Logitech HD Pro Webcam C925e From: Dmitry Fleytman In-Reply-To: <4B8F85D4-C35F-4B36-8196-5F51DA24422F@canonical.com> Date: Tue, 19 Dec 2017 05:52:52 +0200 Cc: Greg Kroah-Hartman , Felipe Balbi , Alan Stern , dmitry , =?utf-8?B?THVrw6HFoSBMYWxpbnNrw70=?= , Daniel Drake , Samuel Thibault , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <73DF6318-5DA0-44E2-8E0D-54F18A6B426F@gmail.com> References: <20171218160454.3895-1-dmitry.fleytman@gmail.com> <4B8F85D4-C35F-4B36-8196-5F51DA24422F@canonical.com> To: Kai-Heng Feng X-Mailer: Apple Mail (2.3445.5.20) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBJ3r3nK013961 Content-Length: 1800 Lines: 52 > On 18 Dec 2017, at 20:07, Kai-Heng Feng wrote: > > Hi, > >> On 19 Dec 2017, at 12:04 AM, Dmitry Fleytman wrote: >> >> From: Dmitry Fleytman Dmitry Fleytman >> >> Commit e0429362ab15 >> ("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") >> introduced quirk to workaround an issue with some Logitech webcams. >> >> There is one more model that has the same issue - C925e, so applying >> the same quirk as well. >> >> See aforementioned commit message for detailed explanation of the problem. >> >> Signed-off-by: Dmitry Fleytman >> --- >> drivers/usb/core/quirks.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c >> index a10b346b9777..6d2d3b0bcc2a 100644 >> --- a/drivers/usb/core/quirks.c >> +++ b/drivers/usb/core/quirks.c >> @@ -52,10 +52,11 @@ static const struct usb_device_id usb_quirk_list[] = { >> /* Microsoft LifeCam-VX700 v2.0 */ >> { USB_DEVICE(0x045e, 0x0770), .driver_info = USB_QUIRK_RESET_RESUME }, >> >> - /* Logitech HD Pro Webcams C920, C920-C and C930e */ >> + /* Logitech HD Pro Webcams C920, C920-C, C925e and C930e */ >> { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT }, >> { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT }, >> { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT }, >> + { USB_DEVICE(0x046d, 0x085B), .driver_info = USB_QUIRK_DELAY_INIT }, > > Nitpicking here, but maybe use 0x085b instead of 0x085B? Yes. Sending v2... > > Kai-Heng > >> >> /* Logitech ConferenceCam CC3000e */ >> { USB_DEVICE(0x046d, 0x0847), .driver_info = USB_QUIRK_DELAY_INIT }, >> -- >> 2.14.1