Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbdLSFIj (ORCPT ); Tue, 19 Dec 2017 00:08:39 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:41856 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbdLSFIi (ORCPT ); Tue, 19 Dec 2017 00:08:38 -0500 X-Google-Smtp-Source: ACJfBouhu6Al+6M+lO83NKxErX14s8H8noebIOJWjLsD81B7tR7bhQmmNOgQwI5hPFJtyE3guWUFOKKxKxTohCzv180= MIME-Version: 1.0 In-Reply-To: <4f7f9c265cbef5f06e3d97d30c1c5f3b3f9aae33.1513609024.git-series.maxime.ripard@free-electrons.com> References: <4f7f9c265cbef5f06e3d97d30c1c5f3b3f9aae33.1513609024.git-series.maxime.ripard@free-electrons.com> From: Chen-Yu Tsai Date: Tue, 19 Dec 2017 13:08:13 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 04/12] drm/sun4i: engine: Add a custom crtc atomic_check To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Chen-Yu Tsai , dri-devel , linux-kernel , linux-arm-kernel , Thomas Petazzoni , Neil Armstrong , thomas@vitsch.nl Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 608 Lines: 15 On Mon, Dec 18, 2017 at 10:57 PM, Maxime Ripard wrote: > We have some restrictions on what the planes and CRTC can provide that are > tied to only one generation of display engines. > > For example, on the first generation, we can only have one YUV plane or one > plane that uses the frontend output. > > Let's allow our engines to provide an atomic_check callback to validate the > current configuration. > > Reviewed-by: Neil Armstrong > Signed-off-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai