From: Dhaval Shah <dhaval.shah@softnautics.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing
 semicolon
Thread-Topic: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing
 semicolon
Thread-Index: AQHTb/xtDCI4izVNEUq1b5g9mIKrEqNJQlYAgADuzI4=
Date: Tue, 19 Dec 2017 05:18:42 +0000
Message-ID: <BM1PR01MB050053D9786A230A2D79F757E60F0@BM1PR01MB0500.INDPRD01.PROD.OUTLOOK.COM>
References: <20171208081305.15153-1-dhaval.shah@softnautics.com>
 <20171208081305.15153-4-dhaval.shah@softnautics.com>,<20171218150200.GA15318@kroah.com>
In-Reply-To: <20171218150200.GA15318@kroah.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b4377cc-6333-43a8-939b-08d5469ff8ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2017 05:18:42.6853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 17b76cff-50c6-4f7a-9198-dd4afc5f8bea
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR01MB0498
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBJ5IrrC030892
Content-Length: 1437
Lines: 39

Hi Greg k-h,

________________________________________
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Monday, December 18, 2017 8:32 PM
> To: Dhaval Shah
> Cc: arnd@arndb.de; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 3/3] misc: ad525x_dpot: macros should not use a trailing semicolon
> 
> On Fri, Dec 08, 2017 at 01:43:05PM +0530, Dhaval Shah wrote:
> > Resolved all the macros should not use a trailing semicolon
> > checkpatch warnings. Issue found by checkpatch.
> >
> > Signed-off-by: Dhaval Shah <dhaval.shah@softnautics.com>
> > ---
> >  drivers/misc/ad525x_dpot.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c
> > index 577f5e76c8a8..bc591b7168db 100644
> > --- a/drivers/misc/ad525x_dpot.c
> > +++ b/drivers/misc/ad525x_dpot.c
> > @@ -515,11 +515,11 @@ set_##_name(struct device *dev, \
> >  #define DPOT_DEVICE_SHOW_SET(name, reg) \
> >  DPOT_DEVICE_SHOW(name, reg) \
> >  DPOT_DEVICE_SET(name, reg) \
> > -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name);
> > +static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name)
> 
> This should be using DEVICE_ATTR_RW() instead of DEVICE_ATTR(), care to
> fix that up in a follow-on patch for this driver?
> 
Sure. I will update this change in follow-on patch for this driver once this patch set merged.

Thanks,
Dhaval
> thanks,
> 
> greg k-h