Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760748AbdLSFZz (ORCPT ); Tue, 19 Dec 2017 00:25:55 -0500 Received: from mail-eopbgr20101.outbound.protection.outlook.com ([40.107.2.101]:20512 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759913AbdLSFZx (ORCPT ); Tue, 19 Dec 2017 00:25:53 -0500 From: "Zhang, Sean C. (NSB - CN/Hangzhou)" To: David Daney , Jan Glauber , "david.daney@cavium.com" CC: "wsa@the-dreams.de" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Bug fix] octeon-i2c driver improvement [2/2] Thread-Topic: [Bug fix] octeon-i2c driver improvement [2/2] Thread-Index: AdNudzzBgpmDJsQORVmDhFwrtvjOdQKEfCcQ Date: Tue, 19 Dec 2017 05:25:49 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [131.228.32.170] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0702MB3615;6:OnBhiHF2w6VJvCV66b2EozFT52YESInrrivhHSgL8vzCZqbdxAII/6cWEbdT9uKEPha8iRtMSd2OXJAjIaykbaGkKUa4cqhSWuiPk50dBt9UlTp6wIawdwe3VL5ROsgj8CxI1qJY+nyoPTndXu5mmsWVvDG/MhHhkrpsht/XtJjdtWjFQ3i9mM+aagKaJ31X6xxDX2uUTGkrjeD13BTgjo8VnwIBZ9jNB+YPV8jpKsicLLUqorFw9NIxiVm7Q9ETje2m/COU3jjzrg4MuEiy/yo+Bz68VYdWaIHLf+ThQEV3IHZpErUNh8rJNKBHlRT271ZlucEcEgqJfvaAcsQQbw+hv8xODcPVDDYSUbFdU4U=;5:l4cTXmLlLLALwv5j4xRtQyUOZF1uIO4bcA3aq6F3MXDbPAb4iFjDkQeS16IxwIW/m76w7CFxkrW7SRE/acPJalerd3eJCVWlWHhgs8pQEPqokwxsOrvupQ0Fqb7ZzrkLrzTnzkiMPO/jQ5D2H0jQwW6NTtu4oRBgi0nsBQCJTyA=;24:JWxzrk5DQtHX9Nj3TBL1ICq7Rlr0vAG4g0rDqCtSf0Nim/BTwglBGvrmA+fPFxAAZuFfbcebmZrrpIQ+2lsOZntVlsM2t2Znxjrg2EoNXn4=;7:oLwsUwVCzNTpOBUNsKpuDfA14DnFUtbXo6C7A8S67etrN1wa+6x5hUmTq/tG2FSFlYjuiAbT1i6C9RFs3f3Lf6D01Uwlt1W0JamK/p6dZYW0/1K86V+GWj2BlmNQxmLdN4G0jw+/2HKAVENiHYvoml5Ff8RwZhdQFwMTPsJy6Q7xDivYXgZa+gPsdeW0u9UHCzKM2UlZu7BfJustf8oljZ/hgPo55RIYXPq9lN81tqFKfPu6zL8AcvnJdjTrvQSK x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e384f39e-a49a-477e-b8dc-08d546a0f6d4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603307);SRVR:VI1PR0702MB3615; x-ms-traffictypediagnostic: VI1PR0702MB3615: authentication-results: spf=none (sender IP is ) smtp.mailfrom=sean.c.zhang@nokia-sbell.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(3231023)(11241501184)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(6072148)(201708071742011);SRVR:VI1PR0702MB3615;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR0702MB3615; x-forefront-prvs: 052670E5A4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(346002)(39860400002)(199004)(189003)(13464003)(6436002)(6246003)(54906003)(76176011)(316002)(110136005)(14454004)(9686003)(55016002)(2900100001)(229853002)(7696005)(2501003)(99286004)(5250100002)(6506007)(5890100001)(66066001)(53546011)(8676002)(3846002)(81156014)(86362001)(81166006)(6116002)(2950100002)(305945005)(74316002)(7736002)(5660300001)(102836003)(478600001)(53936002)(33656002)(8936002)(25786009)(2906002)(4326008)(106356001)(3280700002)(105586002)(68736007)(97736004)(3660700001);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0702MB3615;H:VI1PR0702MB3615.eurprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: nokia-sbell.com X-MS-Exchange-CrossTenant-Network-Message-Id: e384f39e-a49a-477e-b8dc-08d546a0f6d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2017 05:25:49.1547 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0702MB3615 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBJ5PxkI001554 Content-Length: 1139 Lines: 28 Hi Jan and David, Any other comment for these three patches? I sent them separately. 1. [Bug fix] octeon-i2c driver updates 2. [Bug fix] octeon-i2c driver improvement [1/2] 3. [Bug fix] octeon-i2c driver improvement [2/2] BR, Sean Zhang -----Original Message----- From: Zhang, Sean C. (NSB - CN/Hangzhou) Sent: Wednesday, December 06, 2017 5:51 PM To: 'David Daney' ; 'Jan Glauber' ; 'david.daney@cavium.com' Cc: 'wsa@the-dreams.de' ; 'linux-i2c@vger.kernel.org' ; 'linux-kernel@vger.kernel.org' Subject: [Bug fix] octeon-i2c driver improvement [2/2] Hi Jan and David, For octeon-i2c driver, there has duplicated interrupt disable in octeon_i2c_isr(), octeon_i2c_hlc_wait() and octeon_i2c_wait(), since octeon_i2c_hlc_wait() and octeon_i2c_wait() has pair of interrupt enable and disable, so the interrupt disable in octeon_i2c_isr() is not necessary. attached patch removed this unnecessary interrupt disable step. Please have time to review it. Thanks. BR Sean Zhang