Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761316AbdLSGFM (ORCPT ); Tue, 19 Dec 2017 01:05:12 -0500 Received: from mhqcas01.moxa.com ([59.124.42.188]:12326 "EHLO mhqmail.moxa.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760808AbdLSGFL (ORCPT ); Tue, 19 Dec 2017 01:05:11 -0500 X-Greylist: delayed 326 seconds by postgrey-1.27 at vger.kernel.org; Tue, 19 Dec 2017 01:05:10 EST From: =?utf-8?B?U1ogTGluICjmnpfkuIrmmbop?= To: =?utf-8?B?QmrDuHJuIE1vcms=?= CC: Johan Hovold , =?utf-8?B?VGFpeWkgVFkgV3UgKOWQs+azsOavhSk=?= , "Greg Kroah-Hartman" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5 Thread-Topic: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5 Thread-Index: AQHTeDAviVqZBkCTo0edx96w1uvB3KNKIVHw Date: Tue, 19 Dec 2017 05:59:42 +0000 Message-ID: <5942081F7727964D830FC876E62CA85601194755CD@MHQMBX01.moxa.com> References: <20171215103203.2579-1-sz.lin@moxa.com> <20171218165248.GF3374@localhost> <87lghzc1vs.fsf@miraculix.mork.no> In-Reply-To: <87lghzc1vs.fsf@miraculix.mork.no> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.4.141] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBJ65HSK021644 Content-Length: 1307 Lines: 32 > -----Original Message----- > From: Bjørn Mork [mailto:bjorn@mork.no] > Sent: Tuesday, December 19, 2017 2:44 AM > To: SZ Lin (林上智) > Cc: Johan Hovold; Taiyi TY Wu (吳泰毅); Greg Kroah-Hartman; > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5 > > Johan Hovold writes: > > >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { > >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; > > > > Do you really need to blacklist the first interface? > > Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG function, based > on two bulk endpoints, no additional descriptors and the fact that it is the first interface. > If so, then we do want a serial driver for it. There is a basic libqcdm implementation in > ModemManager if you want to test it out. > I have confirmed that interface #0 is QCDM/DIAG port in this module, and thus I will remove this from reserved list in next patch. Furthermore, interface #1 is ADB port. Should I also remove this from reserved list? > And I expect interface #4 is QMI/rmnet? Feel free to confirm that assumption with a > patch against qmi_wwan :-) > Yes, it is. I will send qmi_wwan patch by all means. > > Bjørn SZ