Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761335AbdLSGOc (ORCPT ); Tue, 19 Dec 2017 01:14:32 -0500 Received: from canardo.mork.no ([148.122.252.1]:38387 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761315AbdLSGOa (ORCPT ); Tue, 19 Dec 2017 01:14:30 -0500 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: =?utf-8?B?U1ogTGluICjmnpfkuIrmmbop?= Cc: Johan Hovold , =?utf-8?B?VGFpeWkgVFkgV3UgKOWQsw==?= =?utf-8?B?5rOw5q+FKQ==?= , "Greg Kroah-Hartman" , "linux-usb\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5 Organization: m References: <20171215103203.2579-1-sz.lin@moxa.com> <20171218165248.GF3374@localhost> <87lghzc1vs.fsf@miraculix.mork.no> <5942081F7727964D830FC876E62CA85601194755CD@MHQMBX01.moxa.com> Date: Tue, 19 Dec 2017 07:14:17 +0100 In-Reply-To: <5942081F7727964D830FC876E62CA85601194755CD@MHQMBX01.moxa.com> ("SZ Lin =?utf-8?B?KOael+S4iuaZuikiJ3M=?= message of "Tue, 19 Dec 2017 05:59:42 +0000") Message-ID: <878tdzb5xi.fsf@miraculix.mork.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBJ6EgB6024887 Content-Length: 1398 Lines: 36 "SZ Lin (林上智)" writes: >> Johan Hovold writes: >> >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; >> > >> > Do you really need to blacklist the first interface? >> >> Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG function, based >> on two bulk endpoints, no additional descriptors and the fact that it is the first interface. >> If so, then we do want a serial driver for it. There is a basic libqcdm implementation in >> ModemManager if you want to test it out. >> > > I have confirmed that interface #0 is QCDM/DIAG port in this module, >and thus I will remove this from reserved list in next patch. >Furthermore, interface #1 is ADB port. Should I also remove this from >reserved list? No. ADB is handled by userspace tools using libusb. It should not be bound to any serial driver, so you will need to blacklist it. But you need to keep the blacklist anyway to include the QCDM/DIAG port I assume Johan's alternative was to match class/subclass/protocol against ff/00/00, which would have worked if you only wanted to include interfaces 2 and 3. >> And I expect interface #4 is QMI/rmnet? Feel free to confirm that assumption with a >> patch against qmi_wwan :-) >> > Yes, it is. I will send qmi_wwan patch by all means. Thanks Bjørn