Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938214AbdLSGlq (ORCPT ); Tue, 19 Dec 2017 01:41:46 -0500 Received: from mga04.intel.com ([192.55.52.120]:5921 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937596AbdLSGll (ORCPT ); Tue, 19 Dec 2017 01:41:41 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,425,1508828400"; d="scan'208";a="3656343" From: Kemi Wang To: Greg Kroah-Hartman , Andrew Morton , Michal Hocko , Vlastimil Babka , Mel Gorman , Johannes Weiner , Christopher Lameter , YASUAKI ISHIMATSU , Andrey Ryabinin , Nikolay Borisov , Pavel Tatashin , David Rientjes , Sebastian Andrzej Siewior Cc: Dave , Andi Kleen , Tim Chen , Jesper Dangaard Brouer , Ying Huang , Aaron Lu , Aubrey Li , Kemi Wang , Linux MM , Linux Kernel Subject: [PATCH v2 3/5] mm: enlarge NUMA counters threshold size Date: Tue, 19 Dec 2017 14:39:24 +0800 Message-Id: <1513665566-4465-4-git-send-email-kemi.wang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513665566-4465-1-git-send-email-kemi.wang@intel.com> References: <1513665566-4465-1-git-send-email-kemi.wang@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1522 Lines: 53 We have seen significant overhead in cache bouncing caused by NUMA counters update in multi-threaded page allocation. See 'commit 1d90ca897cb0 ("mm: update NUMA counter threshold size")' for more details. This patch updates NUMA counters to a fixed size of (MAX_S16 - 2) and deals with global counter update using different threshold size for node page stats. Signed-off-by: Kemi Wang --- mm/vmstat.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 9c681cc..64e08ae 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -30,6 +30,8 @@ #include "internal.h" +#define VM_NUMA_STAT_THRESHOLD (S16_MAX - 2) + #ifdef CONFIG_NUMA int sysctl_vm_numa_stat = ENABLE_NUMA_STAT; @@ -394,7 +396,11 @@ void __inc_node_state(struct pglist_data *pgdat, enum node_stat_item item) s16 v, t; v = __this_cpu_inc_return(*p); - t = __this_cpu_read(pcp->stat_threshold); + if (item >= NR_VM_NUMA_STAT_ITEMS) + t = __this_cpu_read(pcp->stat_threshold); + else + t = VM_NUMA_STAT_THRESHOLD; + if (unlikely(v > t)) { s16 overstep = t >> 1; @@ -549,7 +555,10 @@ static inline void mod_node_state(struct pglist_data *pgdat, * Most of the time the thresholds are the same anyways * for all cpus in a node. */ - t = this_cpu_read(pcp->stat_threshold); + if (item >= NR_VM_NUMA_STAT_ITEMS) + t = this_cpu_read(pcp->stat_threshold); + else + t = VM_NUMA_STAT_THRESHOLD; o = this_cpu_read(*p); n = delta + o; -- 2.7.4