Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965538AbdLSGmM (ORCPT ); Tue, 19 Dec 2017 01:42:12 -0500 Received: from mga04.intel.com ([192.55.52.120]:5921 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938154AbdLSGlp (ORCPT ); Tue, 19 Dec 2017 01:41:45 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,425,1508828400"; d="scan'208";a="3656355" From: Kemi Wang To: Greg Kroah-Hartman , Andrew Morton , Michal Hocko , Vlastimil Babka , Mel Gorman , Johannes Weiner , Christopher Lameter , YASUAKI ISHIMATSU , Andrey Ryabinin , Nikolay Borisov , Pavel Tatashin , David Rientjes , Sebastian Andrzej Siewior Cc: Dave , Andi Kleen , Tim Chen , Jesper Dangaard Brouer , Ying Huang , Aaron Lu , Aubrey Li , Kemi Wang , Linux MM , Linux Kernel Subject: [PATCH v2 4/5] mm: use node_page_state_snapshot to avoid deviation Date: Tue, 19 Dec 2017 14:39:25 +0800 Message-Id: <1513665566-4465-5-git-send-email-kemi.wang@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513665566-4465-1-git-send-email-kemi.wang@intel.com> References: <1513665566-4465-1-git-send-email-kemi.wang@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2423 Lines: 65 To avoid deviation, this patch uses node_page_state_snapshot instead of node_page_state for node page stats query. e.g. cat /proc/zoneinfo cat /sys/devices/system/node/node*/vmstat cat /sys/devices/system/node/node*/numastat As it is a slow path and would not be read frequently, I would worry about it. Signed-off-by: Kemi Wang --- drivers/base/node.c | 17 ++++++++++------- mm/vmstat.c | 2 +- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/base/node.c b/drivers/base/node.c index a045ea1..cf303f8 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -169,12 +169,15 @@ static ssize_t node_read_numastat(struct device *dev, "interleave_hit %lu\n" "local_node %lu\n" "other_node %lu\n", - node_page_state(NODE_DATA(dev->id), NUMA_HIT), - node_page_state(NODE_DATA(dev->id), NUMA_MISS), - node_page_state(NODE_DATA(dev->id), NUMA_FOREIGN), - node_page_state(NODE_DATA(dev->id), NUMA_INTERLEAVE_HIT), - node_page_state(NODE_DATA(dev->id), NUMA_LOCAL), - node_page_state(NODE_DATA(dev->id), NUMA_OTHER)); + node_page_state_snapshot(NODE_DATA(dev->id), NUMA_HIT), + node_page_state_snapshot(NODE_DATA(dev->id), NUMA_MISS), + node_page_state_snapshot(NODE_DATA(dev->id), + NUMA_FOREIGN), + node_page_state_snapshot(NODE_DATA(dev->id), + NUMA_INTERLEAVE_HIT), + node_page_state_snapshot(NODE_DATA(dev->id), NUMA_LOCAL), + node_page_state_snapshot(NODE_DATA(dev->id), + NUMA_OTHER)); } static DEVICE_ATTR(numastat, S_IRUGO, node_read_numastat, NULL); @@ -194,7 +197,7 @@ static ssize_t node_read_vmstat(struct device *dev, for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) n += sprintf(buf+n, "%s %lu\n", vmstat_text[i + NR_VM_ZONE_STAT_ITEMS], - node_page_state(pgdat, i)); + node_page_state_snapshot(pgdat, i)); return n; } diff --git a/mm/vmstat.c b/mm/vmstat.c index 64e08ae..d65f28d 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1466,7 +1466,7 @@ static void zoneinfo_show_print(struct seq_file *m, pg_data_t *pgdat, for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) { seq_printf(m, "\n %-12s %lu", vmstat_text[i + NR_VM_ZONE_STAT_ITEMS], - node_page_state(pgdat, i)); + node_page_state_snapshot(pgdat, i)); } } seq_printf(m, -- 2.7.4