Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935078AbdLSHjG (ORCPT <rfc822;w@1wt.eu>);
        Tue, 19 Dec 2017 02:39:06 -0500
Received: from mail-yb0-f195.google.com ([209.85.213.195]:37674 "EHLO
        mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934778AbdLSHjB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 19 Dec 2017 02:39:01 -0500
X-Google-Smtp-Source: ACJfBotCOFlvSIX8QqKZ4I+q1rnidoR9KyMvlDIZ0mJVK8tjJ33nJ1emtFiLLkyTF5ydRrsyYMFipHhU+g3Cgr375oA=
MIME-Version: 1.0
In-Reply-To: <20171218174235.GA113663@google.com>
References: <20171216011230.107527-1-briannorris@chromium.org>
 <20171216031738.GA220575@google.com> <CAFv8Nw+qiWedqZeVsPn17WiSyc_zwOP3bEnxn2Wc-oQ3ntgq2g@mail.gmail.com>
 <20171218174235.GA113663@google.com>
From: Cheng-yi Chiang <cychiang@chromium.org>
Date: Tue, 19 Dec 2017 15:38:30 +0800
X-Google-Sender-Auth: pQotNdqZPztniFWXDMIe1EnZyFw
Message-ID: <CAFv8Nw+bcVSugD5hEBj7nQSg3VGj2E+ROpzf+5LxexEmFoX=oA@mail.gmail.com>
Subject: Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"
To: Brian Norris <briannorris@chromium.org>
Cc: Mark Brown <broonie@kernel.org>, Oder Chiou <oder_chiou@realtek.com>,
        Bard Liao <bardliao@realtek.com>, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        Matthias Kaehlcke <mka@chromium.org>,
        Jeffy Chen <jeffy.chen@rock-chips.com>,
        linux-rockchip@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1044
Lines: 26

Hi Brian, I am sorry for not using the plain text mode in the previous mail.
I agree with you on other points.

On Tue, Dec 19, 2017 at 1:42 AM, Brian Norris <briannorris@chromium.org> wrote:
> Hi!
>
> (By the way, your mail is HTML and likely will get rejected by many
> mailing lists and/or people reading these mailing lists.)
>
> On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote:
>>    Hi Brian,
>>      Oder has posted the same fix : [1]https://patchwork.kernel.org/
>>    patch/10066257/ and it has been applied.
>
> OK cool. Obviously I'm biased, but I prefer mine, as it has less
> needless whitespace, and is appropriately documented ;) But it should be
> a fine replacement.
>
>>    Perhaps you can cherry-pick it to v4.15 ?
>
> I have no say in that; that would be up to Mark, I think. It's most
> certainly a regression in 4.15-rc1, so IMO it should be given a proper
> 'Fixes: e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule
> data copy in resume function")' tag and sent for 4.15, not 4.16.
>
> Brian