Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759631AbdLSIDO (ORCPT ); Tue, 19 Dec 2017 03:03:14 -0500 Received: from mga04.intel.com ([192.55.52.120]:11047 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752723AbdLSIDM (ORCPT ); Tue, 19 Dec 2017 03:03:12 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,425,1508828400"; d="scan'208";a="2980008" Subject: Re: [PATCH 2/3] mmc: sdhci-pci-o2micro: Add eMMC HS200 support To: LinuxPatchCommit , "ulf.hansson@linaro.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Shirley Her (SC)" References: From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Tue, 19 Dec 2017 10:02:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 44 On 04/12/17 12:10, LinuxPatchCommit wrote: > Dear all, A greeting is not needed in a commit message. > > Add register definition for eMMC HS200 mode. > Add hardware tuning for eMMC HS200 mode. > > Signed-off-by: ernest.zhang > --- > drivers/mmc/host/sdhci-pci-o2micro.h | 3 +++ sdhci-pci-o2micro.h was removed by commit 361eeda0ca16 ("mmc: sdhci-pci: Tidy o2micro definitions"). Please re-base. > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pci-o2micro.h b/drivers/mmc/host/sdhci-pci-o2micro.h > index 770f53857211..3fb957729315 100644 > --- a/drivers/mmc/host/sdhci-pci-o2micro.h > +++ b/drivers/mmc/host/sdhci-pci-o2micro.h > @@ -49,6 +49,7 @@ > #define O2_SD_MISC_CTRL4 0xFC > #define O2_SD_TUNING_CTRL 0x300 > #define O2_SD_PLL_SETTING 0x304 > +#define O2_SD_MISC_SETTING 0x308 > #define O2_SD_CLK_SETTING 0x328 > #define O2_SD_CAP_REG2 0x330 > #define O2_SD_CAP_REG0 0x334 > @@ -62,6 +63,8 @@ > #define O2_SD_FREG4_ENABLE_CLK_SET BIT(22) > > #define O2_SD_VENDOR_SETTING 0x110 > +#define O2_SD_HW_TUNING_ENABLE BIT(4) Both these definitions are needed in patch 1. It would be better to add them in that patch. > + > #define O2_SD_VENDOR_SETTING2 0x1C8 > > extern int sdhci_pci_o2_probe_slot(struct sdhci_pci_slot *slot); >