Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933494AbdLSIhT (ORCPT ); Tue, 19 Dec 2017 03:37:19 -0500 Received: from mail-wr0-f170.google.com ([209.85.128.170]:38112 "EHLO mail-wr0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759093AbdLSIhK (ORCPT ); Tue, 19 Dec 2017 03:37:10 -0500 X-Google-Smtp-Source: ACJfBovFKTzbrJnSekoD3bnoTJLib9HXdfs5MnMdId5rn37t/krSpBCOoZcGPd5V6fPD/JVp+v0hzQUqasv5WAFnOwI= MIME-Version: 1.0 In-Reply-To: References: <1507722788-31224-1-git-send-email-radoslaw.pietrzyk@gmail.com> <990c3275-35b3-68da-453c-d1a80e867df7@st.com> <2d892fec-0496-8a6f-51c9-439b933d9975@st.com> <20171207105229.jxxyfofsgub27nip@ninjato> From: =?UTF-8?Q?Rados=C5=82aw_Pietrzyk?= Date: Tue, 19 Dec 2017 09:37:08 +0100 Message-ID: Subject: Re: [PATCH] i2c: stm32: Fixes multibyte transfer for STM32F4 I2C controller To: Pierre Yves MORDRET Cc: Wolfram Sang , Maxime Coquelin , Alexandre Torgue , "open list:I2C SUBSYSTEM" , "moderated list:ARM/STM32 ARCHITECTURE" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBJ8bN1n011433 Content-Length: 895 Lines: 23 My understanding is that this driver is currently vulnerable to any IRQ delays that may happen in the system and this patch eliminates the problem but you may prove me wrong. 2017-12-07 14:23 GMT+01:00 Pierre Yves MORDRET : > > I do believe some investigation has to be done prior merging this patch. > The impact is genuine and has to be tested thoroughly before granting an ack. > > Thus I prefer having a better understanding of the issue. > I will try to work on this later on. > > Regards > > > On 12/07/2017 11:52 AM, Wolfram Sang wrote: >> On Tue, Oct 24, 2017 at 01:45:43PM +0200, Radosław Pietrzyk wrote: >>> I'm afraid that didn't help and the problem still exists even with >>> those patches applied. >> >> So, my reading is: There is an issue which needs to be investigated? >> Does applying the patch make sense until the issue is fully understood? >>