Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938856AbdLSJRv (ORCPT ); Tue, 19 Dec 2017 04:17:51 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:37965 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S938734AbdLSJRs (ORCPT ); Tue, 19 Dec 2017 04:17:48 -0500 Subject: Re: [PATCH V2 9/9] ARM: dts: stm32: add initial support of stm32mp157c eval board To: Arnd Bergmann , Ludovic Barre CC: Russell King , Rob Herring , Linus Walleij , Maxime Coquelin , Gerald Baeza , Linux ARM , Linux Kernel Mailing List , DTML References: <1513610272-7824-1-git-send-email-ludovic.Barre@st.com> <1513610272-7824-10-git-send-email-ludovic.Barre@st.com> From: Alexandre Torgue Message-ID: <42407e75-7e27-2c68-9993-37865c57a9fd@st.com> Date: Tue, 19 Dec 2017 10:17:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG1NODE2.st.com (10.75.127.2) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-19_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 836 Lines: 30 Hi, On 12/18/2017 09:20 PM, Arnd Bergmann wrote: > On Mon, Dec 18, 2017 at 4:17 PM, Ludovic Barre wrote: > = >> + >> +/ { >> + model = "STMicroelectronics STM32MP157C eval daughter"; >> + compatible = "st,stm32mp157c-ed1", "st,stm32mp157"; >> + >> + chosen { >> + bootargs = "earlyprintk console=ttySTM3,115200 root=/dev/ram"; >> + stdout-path = "serial3:115200n8"; >> + }; > > I'd remove the bootargs here and let the boot loader take care of > that, in particular > since all three arguments are rather old-school: earlycon is preferred over > earlyprintk, console= should not be needed if you set stdout-path, and > /dev/ram is obsoleted by initramfs. In this case I will modify also stm32 mcu devicetree in this way. Thanks Alex > > Arnd >